This revision was automatically updated to reflect the committed changes.
Closed by commit rG419001724542: [clangd] Add tests covering existing
header-guard behavior. NFC (authored by sammccall).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106201/n
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks!
Comment at: clang-tools-extra/clangd/unittests/ParsedASTTests.cpp:725
+ TU.Code = R"cpp(
+#pragma once
+;
sammccall wrote:
> kadircet wr
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/unittests/ParsedASTTests.cpp:725
+ TU.Code = R"cpp(
+#pragma once
+;
kadircet wrote:
> ```
> #include "self.h"
> #pragma once
> ```
>
> might also be an interesting case (with preambl
sammccall updated this revision to Diff 359771.
sammccall marked 5 inline comments as done.
sammccall added a comment.
Added cases to address comments, and added comments about semicolons.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106201/new/
h
kadircet added a comment.
i mostly agree with the desired behaviours laid out by the tests, mentioned a
coupe extra cases and wrinkly looking parts in comments.
Comment at: clang-tools-extra/clangd/unittests/ParsedASTTests.cpp:724
+
+ TU.Code = R"cpp(
+#pragma once
--
sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: usaxena95, arphaman.
sammccall requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
A few different mechanisms he
