[PATCH] D106137: [flang][driver] Add support for Frontend Plugins

awarzynski added a comment. In D106137#2941616 , @DavidSpickett wrote: > This has broken cmake config on the out of tree flang bot: > https://lab.llvm.org/buildbot/#/builders/175/builds/2026 > > (with perhaps the least helpful cmake error I've ever seen)

[PATCH] D106137: [flang][driver] Add support for Frontend Plugins

DavidSpickett added a comment. This has broken cmake config on the out of tree flang bot: https://lab.llvm.org/buildbot/#/builders/175/builds/2026 (with perhaps the least helpful cmake error I've ever seen) Not personally familiar with what "out of tree" means for flang but you should be able t

[PATCH] D106137: [flang][driver] Add support for Frontend Plugins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf52fc591fa34: [flang][driver] Add support for Frontend Plugins (authored by stuartellis, committed by awarzynski). Repository: rG LLVM Github Mono

[PATCH] D106137: [flang][driver] Add support for Frontend Plugins

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106137/new/ https://reviews.llvm.org/D106137 __

[PATCH] D106137: [flang][driver] Add support for Frontend Plugins

stuartellis updated this revision to Diff 365411. stuartellis marked an inline comment as done. stuartellis added a comment. Address review comments Small changes due to rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106137/new/ https://revie

[PATCH] D106137: [flang][driver] Add support for Frontend Plugins

awarzynski added a comment. I think that this is almost ready to be merged. Just a couple more comments. Comment at: flang/examples/CMakeLists.txt:1 # This test is not run by default as it requires input. add_executable(external-hello-world Could you add the

[PATCH] D106137: [flang][driver] Add support for Frontend Plugins

stuartellis marked 9 inline comments as done. stuartellis added inline comments. Comment at: flang/lib/FrontendTool/ExecuteCompilerInvocation.cpp:92 +unsigned diagID = ci.diagnostics().getCustomDiagID( +clang::DiagnosticsEngine::Error, "unable to find plugin '%0'"); +

[PATCH] D106137: [flang][driver] Add support for Frontend Plugins

stuartellis updated this revision to Diff 360887. stuartellis added a comment. Address review comments Added some comments to a couple of places Added new `FLANG_PLUGIN_SUPPORT` CMake flag to control exporting executable symbols Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106137: [flang][driver] Add support for Frontend Plugins

awarzynski added a comment. @stuartellis , thank you for working on this! I've left a few comments - mostly nits. Comment at: flang/examples/HelloWorld/CMakeLists.txt:1-5 +add_llvm_library( +flangHelloWorldPlugin +MODULE +HelloWorldPlugin.cpp +) I

[PATCH] D106137: [flang][driver] Add support for Frontend Plugins

stuartellis created this revision. Herald added subscribers: dang, mgorny. Herald added a reviewer: sscalpone. Herald added a reviewer: awarzynski. stuartellis requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Introducing a plugin API and a s