This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9451403c5f8c: [OPENCL] opencl-c.h: add initial CL 3.0
conditionals for atomic operations. (authored by airlied).
Changed prior to commit:
https://
airlied updated this revision to Diff 360349.
airlied added a comment.
add conditional around memory_order_seq_cst
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106111/new/
https://reviews.llvm.org/D106111
Files:
clang/lib/Headers/opencl-c-base.
azabaznov added a comment.
You also need to guard //memory_order_seq_cst// enum entry. Note that
//memory_order_acq_rel// is always defined as it can be used in
//atomic_work_item_fence()// built-in function, AFAIR in all other cases if
//memory_order_acq_rel// is used without //__opencl_c_atom
Anastasia added a subscriber: azabaznov.
Anastasia added a comment.
CC @azabaznov in case he has any feedback.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106111/new/
https://reviews.llvm.org/D106111
_
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106111/new/
https://reviews.llvm.org/D106111
airlied created this revision.
airlied added a project: clang.
Herald added subscribers: ldrumm, jfb, Anastasia, yaxunl.
airlied requested review of this revision.
Herald added a subscriber: cfe-commits.
This adds the optional wrappers around things, however this isn't sufficient
yet for CL 3.0 w
