[PATCH] D105997: Implement _ExtInt conversion rules

2021-07-22 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the reviews; I've committed in 6bb042e70024354acc65457e153b40d50cada4f5 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105997/new/ https:

[PATCH] D105997: Implement _ExtInt conversion rules

2021-07-19 Thread Melanie Blower via Phabricator via cfe-commits
mibintc accepted this revision. mibintc added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105997/new/ https://reviews.llvm.org/D105997 ___ cfe-commits mailing list cfe-commits

[PATCH] D105997: Implement _ExtInt conversion rules

2021-07-19 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. Ping. FWIW, I'm hoping to get these changes into the Clang 13 branch before we split off. I don't think we'll get fully conforming support for the feature in Clang 13 (we need some ABI discussion before I think we'll be ready to rename `_ExtInt` to `_BitInt`, but

[PATCH] D105997: Implement _ExtInt conversion rules

2021-07-14 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman updated this revision to Diff 358663. aaron.ballman added a comment. Added more test coverage in C for conversion type results. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105997/new/ https://reviews.llvm.org/D105997 Files: clang/lib/Sema/SemaExpr.cpp clang/test/Sem

[PATCH] D105997: Implement _ExtInt conversion rules

2021-07-14 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/test/Sema/ext-int.c:7 _ExtInt(32) s32, int b) { - b ? s30 : s31a; // expected-error{{incompatible operand types}} - b ? s31a : s30; // expected-error{{incompatible operand types}} - b ? s32 : 0; // expected-e

[PATCH] D105997: Implement _ExtInt conversion rules

2021-07-14 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added inline comments. Comment at: clang/test/Sema/ext-int.c:7 _ExtInt(32) s32, int b) { - b ? s30 : s31a; // expected-error{{incompatible operand types}} - b ? s31a : s30; // expected-error{{incompatible operand types}} - b ? s32 : 0; // expected-error{{i

[PATCH] D105997: Implement _ExtInt conversion rules

2021-07-14 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added inline comments. Comment at: clang/test/Sema/ext-int.c:7 _ExtInt(32) s32, int b) { - b ? s30 : s31a; // expected-error{{incompatible operand types}} - b ? s31a : s30; // expected-error{{incompatible operand types}} - b ? s32 : 0; // expected-erro

[PATCH] D105997: Implement _ExtInt conversion rules

2021-07-14 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/test/Sema/ext-int.c:7 _ExtInt(32) s32, int b) { - b ? s30 : s31a; // expected-error{{incompatible operand types}} - b ? s31a : s30; // expected-error{{incompatible operand types}} - b ? s32 : 0; // expected-e

[PATCH] D105997: Implement _ExtInt conversion rules

2021-07-14 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added inline comments. Comment at: clang/test/Sema/ext-int.c:7 _ExtInt(32) s32, int b) { - b ? s30 : s31a; // expected-error{{incompatible operand types}} - b ? s31a : s30; // expected-error{{incompatible operand types}} - b ? s32 : 0; // expected-erro

[PATCH] D105997: Implement _ExtInt conversion rules

2021-07-14 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, erichkeane, mibintc, jyknight, rjmccall. aaron.ballman requested review of this revision. Herald added a project: clang. Clang implemented the _ExtInt datatype as a bit-precise integer type, which was then proposed to WG1