[PATCH] D105960: [clang][driver][darwin] Add driver support for Mac Catalyst

2021-07-22 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. In D105960#2897310 , @arphaman wrote: > I think this should be fixed in 40d2d0c41298f1d8a178216e2534b29e3128cf37 > . Thanks. Confirmed the test passes loca

[PATCH] D105960: [clang][driver][darwin] Add driver support for Mac Catalyst

2021-07-22 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. I think this should be fixed in 40d2d0c41298f1d8a178216e2534b29e3128cf37 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105960/new/ https://reviews.llv

[PATCH] D105960: [clang][driver][darwin] Add driver support for Mac Catalyst

2021-07-22 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. I think this should be fixed if I add `-fuse-ld=` to the invocation. Let me commit that fix to see if it's fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105960/new/ https://reviews.llvm.org/D105960 ___

[PATCH] D105960: [clang][driver][darwin] Add driver support for Mac Catalyst

2021-07-22 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. In D105960#2897245 , @leonardchan wrote: > Hi. I think this patch may have led to the test failure we're seeing on our > clang builders > (https://luci-milo.appspot.com/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b88409869

[PATCH] D105960: [clang][driver][darwin] Add driver support for Mac Catalyst

2021-07-22 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. Hi. I think this patch may have led to the test failure we're seeing on our clang builders (https://luci-milo.appspot.com/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8840986998954824016): Command Output (stderr): -- /b/s/w/ir/x/w/llvm-project/clang/test/D

[PATCH] D105960: [clang][driver][darwin] Add driver support for Mac Catalyst

2021-07-22 Thread Alex Lorenz via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2542c1a5a130: [clang][driver][darwin] Add driver support for Mac Catalyst (authored by arphaman). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D105960: [clang][driver][darwin] Add driver support for Mac Catalyst

2021-07-14 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM! (Maybe leave a couple of days in case others have comments.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105960/new/ https://rev

[PATCH] D105960: [clang][driver][darwin] Add driver support for Mac Catalyst

2021-07-13 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman created this revision. arphaman added reviewers: dexonsmith, Bigcheese. Herald added a subscriber: ributzka. arphaman requested review of this revision. Herald added a project: clang. This patch is the last patch in the series of patches for the Mac Catalyst support in clang. It adds dri