[PATCH] D105951: [clang] P2266 implicit moves STL workaround

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG20555a15a596: [clang] P2266 implicit moves STL workaround (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105951/new/ https://reviews.llvm.org/D105951 ___ cfe-commits mailing li

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

mibintc accepted this revision. mibintc added a comment. This revision is now accepted and ready to land. I tested this patch downstream on Windows with Microsoft (R) C/C++ Optimizing Compiler Version 19.28.29334 for x64 I used c++20, x++latest default and c++17 with the stl header files (standa

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

mizvekov added a comment. If you think landing this in 13 after the release branch is created will be complicated, then please consider this message a gentle **Ping** :) Frankly, I am satisfied with the mechanics of this workaround as is. - After another look, I think doing something more targe

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

mizvekov updated this revision to Diff 360660. mizvekov added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105951/new/ https://reviews.llvm.org/D105951 Files: clang/include/clang/Sema/Sema.h clang/lib/Frontend/InitPreprocess

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

mizvekov added a comment. In D105951#2894888 , @STL_MSFT wrote: > FYI, we merged https://github.com/microsoft/STL/pull/2025 fixing the 2 > affected `return _Istr;` occurrences in `` and `` for VS > 2022 17.0 Preview 4. If you find any other affected ret

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

STL_MSFT added a comment. FYI, we merged https://github.com/microsoft/STL/pull/2025 fixing the 2 affected `return _Istr;` occurrences in `` and `` for VS 2022 17.0 Preview 4. If you find any other affected return statements, please let us know ASAP (as the VS release process locks down the rele

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

mizvekov added a comment. While we are still reviewing this and it's probably going to take longer, I went ahead made a DR for fixing the same issue in main: https://reviews.llvm.org/D106303 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105951/new

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

mizvekov updated this revision to Diff 359145. mizvekov added a comment. Herald added a subscriber: lxfind. Patch update: - Fixes issue where the workaround would completely supress implicit moves. - Improve tests to cover this issue. - Stop applying the workaround to throw expressions, as we hav

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

aaron.ballman added a comment. In D105951#2880654 , @mibintc wrote: > Intel compiles VS2019 #include files regularly with clang, and the file > compiled with -std:c++latest encounters this error report, which > @aaron.ballman suggests is related to thi

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

mibintc added a comment. Intel compiles VS2019 #include files regularly with clang, and the file compiled with -std:c++latest encounters this error report, which @aaron.ballman suggests is related to this effort. In file included from tst_incl_filesystem.cpp:2: c:/Program files (x86)/Micro

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

mizvekov updated this revision to Diff 358702. mizvekov added a comment. - Small simplification to implementation, don't need to cast to NamespaceDecl. - Simplification to tests: Use some evil prep hackery to avoid needing multipe files. - Verify result of getReferencedDeclOfCallee is non-null.

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3317-3321 + for (const DeclContext *DC = D->getDeclContext(); DC; DC = DC->getParent()) { +if (const auto *NS = dyn_cast(DC)) + if (NS->isStdNamespace()) +return true; + }

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3314 +return false; + const Decl *D = E.getReferencedDeclOfCallee(); + if (!S.SourceMgr.isInSystemHeader(D->getLocation())) aaron.ballman wrote: > This can return `nullptr`, so we shoul

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

aaron.ballman added a comment. Thank you for working on this! We're testing the patch out internally to see if it solves issues for us with some of the failures we're seeing. Comment at: clang/lib/Sema/SemaStmt.cpp:3314 +return false; + const Decl *D = E.getReferencedDecl

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

mizvekov updated this revision to Diff 358488. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105951/new/ https://reviews.llvm.org/D105951 Files: clang/lib/Frontend/InitPreprocessor.cpp clang/lib/Sema/SemaStmt.cpp

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

mizvekov created this revision. mizvekov updated this revision to Diff 358468. mizvekov added a comment. mizvekov updated this revision to Diff 358483. mizvekov published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. . mizvekov added a comment.