[PATCH] D105930: [PowerPC] Implement XL compact math builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc8937b6cb975: [PowerPC] Implement XL compact math builtins (authored by lei). Changed prior to commit: https://reviews.llvm.org/D105930?vs=359070&

[PATCH] D105930: [PowerPC] Implement XL compact math builtins

lei added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.td:3087 // RM should be set. +let hasSideEffects = 1 in { def MTFSB0 : XForm_43<63, 70, (outs), (ins u5imm:$FM), nemanjai wrote: > nemanjai wrote: > > I think we should conservatively s

[PATCH] D105930: [PowerPC] Implement XL compact math builtins

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM other than the comment that wasn't addressed (which I assume will be addressed in a subsequent patch). Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.td:3087 //

[PATCH] D105930: [PowerPC] Implement XL compact math builtins

lei updated this revision to Diff 359070. lei added a comment. rebase to ToT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105930/new/ https://reviews.llvm.org/D105930 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/Basic/Targets/PP

[PATCH] D105930: [PowerPC] Implement XL compact math builtins

lei added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.td:3650 +// XL Compat intrinsics. +def : Pat<(int_ppc_fmsub f64:$A, f64:$B, f64:$C), (FMSUB $A, $B, $C)>; +def : Pat<(int_ppc_fmsubs f32:$A, f32:$B, f32:$C), (FMSUBS $A, $B, $C)>; nemanja

[PATCH] D105930: [PowerPC] Implement XL compact math builtins

lei updated this revision to Diff 359050. lei marked 3 inline comments as done. lei added a comment. Address review comments to add/upate: - builtin encoding for params that need to be folded into constant expr - llvm intrinsic property for immediates - test line for `-mattr=-vsx` Repository:

[PATCH] D105930: [PowerPC] Implement XL compact math builtins

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. Please change `compact` in the title to `compat`. Comment at: clang/include/clang/Basic/BuiltinsPPC.def:76-79 +BUILTIN(__builtin_ppc_mtfsb0, "vUi", "") +BUILTIN

[PATCH] D105930: [PowerPC] Implement XL compact math builtins

lei updated this revision to Diff 358665. lei added a comment. cleanup tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105930/new/ https://reviews.llvm.org/D105930 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/Basic/Targets/PP

[PATCH] D105930: [PowerPC] Implement XL compact math builtins

nemanjai added a subscriber: ZhangKang. nemanjai added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.td:3087 // RM should be set. +let hasSideEffects = 1 in { def MTFSB0 : XForm_43<63, 70, (outs), (ins u5imm:$FM), I think we should conservat

[PATCH] D105930: [PowerPC] Implement XL compact math builtins

lei updated this revision to Diff 358409. lei added a comment. update tc to only check for pwr7 and up Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105930/new/ https://reviews.llvm.org/D105930 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D105930: [PowerPC] Implement XL compact math builtins

lei created this revision. lei added reviewers: stefanp, nemanjai, power-llvm-team. Herald added subscribers: shchenz, hiraditya. lei requested review of this revision. Herald added projects: clang, LLVM. Implement a subset of builtins required for compatiblilty with AIX XL compiler. Repository: