[PATCH] D105911: [CallGraphSection] Introduce CGSectionFuncComdatCreator pass

MaskRay added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1420 + +if (CodeGenOpts.CallGraphSection) { + MPM.addPass(CGSectionFuncComdatCreatorPass()); https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-stateme

[PATCH] D105911: [CallGraphSection] Introduce CGSectionFuncComdatCreator pass

necipfazil abandoned this revision. necipfazil added a comment. In D105911#2878345 , @morehouse wrote: > Are comdats needed? Can we get proper dead stripping with just > `SHF_LINK_ORDER`? It looks like we can. I am abandoning this revision. I will shor

[PATCH] D105911: [CallGraphSection] Introduce CGSectionFuncComdatCreator pass

morehouse added a subscriber: MaskRay. morehouse added a comment. Are comdats needed? Can we get proper dead stripping with just `SHF_LINK_ORDER`? @MaskRay recently updated the documentation for associated metadata to imply that our sym

[PATCH] D105911: [CallGraphSection] Introduce CGSectionFuncComdatCreator pass

necipfazil created this revision. necipfazil added reviewers: lattner, morehouse, kcc, llvm-commits. Herald added subscribers: ormris, hiraditya, mgorny. necipfazil requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. Create comdats for fun