[PATCH] D105892: [NFC] Silence build warning by placing parentheses around condition

2021-07-13 Thread Anton Zabaznov via Phabricator via cfe-commits
azabaznov updated this revision to Diff 358265. azabaznov added a comment. Add comment for C++ for OpenCL, add variable to check support for OpenCL C Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105892/new/ https://reviews.llvm.org/D105892 Files:

[PATCH] D105892: [NFC] Silence build warning by placing parentheses around condition

2021-07-13 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a reviewer: alexfh. aaron.ballman added a comment. Note: https://reviews.llvm.org/D105890 that was just landed to touch the same area. FWIW, I agree that this should probably be using some local variables to make the conditions a bit more clear. Repository: rG LLVM Githu

[PATCH] D105892: [NFC] Silence build warning by placing parentheses around condition

2021-07-13 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. This is not NFC, is it? Before, this got evaluated as `(!S.getLangOpts().OpenCLCPlusPlus && S.getLangOpts().OpenCLVersion < 200) || (S.getLangOpts().OpenCLVersion == 300 && !S.getOpenCLOptions().isSupported("__opencl_c_read_write_images", S.getLangOpts()))`. Now, it's e

[PATCH] D105892: [NFC] Silence build warning by placing parentheses around condition

2021-07-13 Thread Anton Zabaznov via Phabricator via cfe-commits
azabaznov created this revision. azabaznov added reviewers: Anastasia, thakis. Herald added a reviewer: aaron.ballman. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org