MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.
I have confirmed that this matches musl `#define FP_SUFFIX "-sf"`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105869/new/
https://reviews.ll
pattop updated this revision to Diff 390227.
pattop added a comment.
Add test case.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105869/new/
https://reviews.llvm.org/D105869
Files:
clang/lib/Driver/ToolChains/Linux.cpp
clang/test/Driver/linux
MaskRay requested changes to this revision.
MaskRay added a comment.
This revision now requires changes to proceed.
This needs a test like `clang/test/Driver/linux-ld.c` `CHECK-MUSL-PPC`. Use
`ninja check-clang-driver` to test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
jhibbits accepted this revision.
jhibbits added a comment.
This revision is now accepted and ready to land.
Looks fine to me. @nemanjai this one is more Musl, less SPE :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105869/new/
https://reviews.ll
nemanjai added a subscriber: jhibbits.
nemanjai added a comment.
I personally don't see anything wrong with this, but then again I am not really
familiar with SPE. I'll defer to @jhibbits for the approval.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.o
pattop added a comment.
Here is the corresponding gcc patch:
https://github.com/richfelker/musl-cross-make/commit/5b405688ee23df621e5b33911e2aa7b046ef632e
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105869/new/
https://reviews.llvm.org/D105869
pattop created this revision.
Herald added subscribers: steven.zhang, shchenz, nemanjai.
pattop requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Musl treats PowerPC SPE as a soft-float target (as the PowerPC SPE ABI
is soft-float compatible)
