[PATCH] D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all

2023-06-05 Thread Tom Stellard via Phabricator via cfe-commits
tstellar added inline comments. Herald added a subscriber: Enna1. Herald added a project: All. Comment at: compiler-rt/cmake/base-config-ix.cmake:126 +set(COMPILER_RT_INSTALL_DATA_DIR "${default_install_path}" CACHE PATH + "Path where compiler-rt data files should be installed."

[PATCH] D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all

2021-12-08 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added inline comments. Comment at: compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake:509 set(DARWIN_macho_embedded_LIBRARY_OUTPUT_DIR - ${COMPILER_RT_OUTPUT_DIR}/lib/macho_embedded) + ${COMPILER_RT_OUTPUT_LIBRARY_DIR}/macho_embedded) set(DARWIN_ma

[PATCH] D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all

2021-12-08 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added inline comments. Comment at: compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake:509 set(DARWIN_macho_embedded_LIBRARY_OUTPUT_DIR - ${COMPILER_RT_OUTPUT_DIR}/lib/macho_embedded) + ${COMPILER_RT_OUTPUT_LIBRARY_DIR}/macho_embedded) set(DARWIN_ma

[PATCH] D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all

2021-09-21 Thread John Ericson via Phabricator via cfe-commits
Ericson2314 added inline comments. Comment at: compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake:509 set(DARWIN_macho_embedded_LIBRARY_OUTPUT_DIR - ${COMPILER_RT_OUTPUT_DIR}/lib/macho_embedded) + ${COMPILER_RT_OUTPUT_LIBRARY_DIR}/macho_embedded) set(DARWIN

[PATCH] D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all

2021-09-20 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added inline comments. Comment at: compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake:509 set(DARWIN_macho_embedded_LIBRARY_OUTPUT_DIR - ${COMPILER_RT_OUTPUT_DIR}/lib/macho_embedded) + ${COMPILER_RT_OUTPUT_LIBRARY_DIR}/macho_embedded) set(DARWIN_ma

[PATCH] D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all

2021-07-14 Thread John Ericson via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e03c37b97b6: Prepare Compiler-RT for GnuInstallDirs, matching lib

[PATCH] D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all

2021-07-13 Thread Petr Hosek via Phabricator via cfe-commits
phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105765/new/ https://reviews.llvm.org/D105765 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all

2021-07-13 Thread John Ericson via Phabricator via cfe-commits
Ericson2314 added inline comments. Comment at: compiler-rt/docs/BuildingCompilerRT.rst:12-22 +The instructions on this page are aimed at vendors who ship Compiler-RT as part of an +operating system distribution, a toolchain or similar shipping vehicules. If you +are a user mere

[PATCH] D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all

2021-07-13 Thread John Ericson via Phabricator via cfe-commits
Ericson2314 updated this revision to Diff 358057. Ericson2314 marked 2 inline comments as done. Ericson2314 added a comment. Fixes from comments, Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105765/new/ https://reviews.llvm.org/D105765 Fi

[PATCH] D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all

2021-07-13 Thread Petr Hosek via Phabricator via cfe-commits
phosek added inline comments. Comment at: compiler-rt/docs/BuildingCompilerRT.rst:12-22 +The instructions on this page are aimed at vendors who ship Compiler-RT as part of an +operating system distribution, a toolchain or similar shipping vehicules. If you +are a user merely tr

[PATCH] D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all

2021-07-12 Thread John Ericson via Phabricator via cfe-commits
Ericson2314 marked an inline comment as done. Ericson2314 added inline comments. Comment at: compiler-rt/docs/BuildingCompilerRT.rst:12-22 +The instructions on this page are aimed at vendors who ship Compiler-RT as part of an +operating system distribution, a toolchain or simila

[PATCH] D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all

2021-07-12 Thread John Ericson via Phabricator via cfe-commits
Ericson2314 marked an inline comment as done. Ericson2314 added inline comments. Comment at: compiler-rt/cmake/base-config-ix.cmake:97 + else() +set(temp_path "${temp_path}/${current_segment}") + endif() phosek wrote: > This isn't set before so it should be

[PATCH] D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx

2021-07-12 Thread John Ericson via Phabricator via cfe-commits
Ericson2314 updated this revision to Diff 357969. Ericson2314 added a comment. Herald added projects: clang, libc++, libc++abi, libunwind. Herald added subscribers: libcxx-commits, cfe-commits. Herald added a reviewer: libc++. Herald added a reviewer: libc++abi. Herald added a reviewer: libunwind.