This revision was automatically updated to reflect the committed changes.
Closed by commit rGf1aca5ac96eb: [PowerPC] Fix L[D|W]ARX Implementation
(authored by Conanap).
Changed prior to commit:
https://reviews.llvm.org/D105754?vs=358032&id=358289#toc
Repository:
rG LLVM Github Monorepo
CHAN
nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105754/new/
https://reviews.llvm.org/D105754
__
Conanap updated this revision to Diff 358032.
Conanap added a comment.
Updated lwarx test case with modifier
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105754/new/
https://reviews.llvm.org/D105754
Files:
clang/lib/CodeGen/CGBuiltin.cpp
clan
Conanap updated this revision to Diff 358028.
Conanap added a comment.
Updated a test case
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105754/new/
https://reviews.llvm.org/D105754
Files:
clang/lib/CodeGen/CGBuiltin.cpp
clang/test/CodeGen/bui
Conanap added inline comments.
Comment at:
llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-LoadReserve-StoreCond-64bit-only.ll:18
entry:
- %0 = bitcast i64* %a to i8*
- %1 = tail call i64 @llvm.ppc.ldarx(i8* %0)
- ret i64 %1
+ %0 = call i64 asm sideeffect "ldarx $0, $1", "=
nemanjai added inline comments.
Comment at:
llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-LoadReserve-StoreCond-64bit-only.ll:18
entry:
- %0 = bitcast i64* %a to i8*
- %1 = tail call i64 @llvm.ppc.ldarx(i8* %0)
- ret i64 %1
+ %0 = call i64 asm sideeffect "ldarx $0, $1", "
Conanap added inline comments.
Comment at:
llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-LoadReserve-StoreCond-64bit-only.ll:18
entry:
- %0 = bitcast i64* %a to i8*
- %1 = tail call i64 @llvm.ppc.ldarx(i8* %0)
- ret i64 %1
+ %0 = call i64 asm sideeffect "ldarx $0, $1", "=
Conanap updated this revision to Diff 357833.
Conanap added a comment.
Removed unintended change
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105754/new/
https://reviews.llvm.org/D105754
Files:
clang/lib/CodeGen/CGBuiltin.cpp
clang/test/CodeG
Conanap updated this revision to Diff 357832.
Conanap marked 6 inline comments as done.
Conanap added a comment.
Herald added subscribers: frasercrmck, luismarques, apazos, sameer.abuasal,
s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01,
edward-jones, zzheng, MaskRay, jr
nemanjai requested changes to this revision.
nemanjai added a comment.
This revision now requires changes to proceed.
I believe that your failing test case is because you are attempting to emit
code for these builtins in the target independent code and the values just
happen to match up.
lkail added inline comments.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:1015
+break;
+ }
+
Adding `default: llvm_unreachable` would be nice.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105754/new/
https://
lkail added inline comments.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:997
+static llvm::Value *emitLoadReserveIntrinsic(CodeGenFunction &CGF,
+ unsigned BuiltinID,
Maybe rename to `emitPPCLoadReserveIntrinsic` shou
Conanap added a comment.
looking at the failing test cases, for example
`./clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vadd.c`, which are not
test cases compiled for `PPC`, I'm seeing this following error:
clang: /home/conanap/llvm/ccom/llvm-project/llvm/lib/IR/Instructions.cpp:494:
v
nemanjai added inline comments.
Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:1535
- def int_ppc_ldarx : GCCBuiltin<"__builtin_ppc_ldarx">,
- Intrinsic<[llvm_i64_ty], [llvm_ptr_ty], [IntrNoMem]>;
}
lkail wrote:
> Just curious, compi
lkail added inline comments.
Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:1535
- def int_ppc_ldarx : GCCBuiltin<"__builtin_ppc_ldarx">,
- Intrinsic<[llvm_i64_ty], [llvm_ptr_ty], [IntrNoMem]>;
}
Just curious, compiler optimizes the
Conanap updated this revision to Diff 357684.
Conanap added a comment.
Fixed more test cases
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105754/new/
https://reviews.llvm.org/D105754
Files:
clang/lib/CodeGen/CGBuiltin.cpp
clang/test/CodeGen/b
Conanap updated this revision to Diff 357681.
Conanap added a comment.
Added modifier to $1
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105754/new/
https://reviews.llvm.org/D105754
Files:
clang/lib/CodeGen/CGBuiltin.cpp
clang/test/CodeGen/bu
Conanap updated this revision to Diff 357680.
Conanap added a comment.
Update test cases
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105754/new/
https://reviews.llvm.org/D105754
Files:
clang/lib/CodeGen/CGBuiltin.cpp
clang/test/CodeGen/built
Conanap created this revision.
Herald added subscribers: shchenz, kbarton, hiraditya, nemanjai.
Conanap requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
LDARX and LWARX sometimes gets optimized out by the compiler
when it i
19 matches
Mail list logo
