[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka added a comment. In D105703#2898350 , @vitalybuka wrote: > In D105703#2898343 , @vitalybuka > wrote: > >> fix crash > > weird, my config with -DLLVM_ENABLE_ASSERTIONS=ON does not reproduce, however >

[PATCH] D105703: [hwasan] Use stack safety analysis.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG96c63492cb95: [hwasan] Use stack safety analysis. (authored by fmayer, committed by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka added a comment. In D105703#2898343 , @vitalybuka wrote: > fix crash weird, my config with -DLLVM_ENABLE_ASSERTIONS=ON does not reproduce, however exact cmake from bot does Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka updated this revision to Diff 361002. vitalybuka added a comment. fix crash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/hwasa

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:414 INITIALIZE_PASS_BEGIN( HWAddressSanitizerLegacyPass, "hwasan", To fix that revert you need to add INITIALIZE_PASS_DEPENDENCY(StackSafetyGlobalIn

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka added a comment. Do you build with assertions enabled? In D105703#2896056 , @fmayer wrote: > Sorry. broke a buildbot again: > https://lab.llvm.org/buildbot/#/builders/139/builds/7613/steps/6/logs/FAIL__Clang__asan_c > > I am not sure why I ca

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer reopened this revision. fmayer added a comment. This revision is now accepted and ready to land. Sorry. broke a buildbot again: https://lab.llvm.org/buildbot/#/builders/139/builds/7613/steps/6/logs/FAIL__Clang__asan_c I am not sure why I cannot reproduce this locally. Pass 'HWAddressSa

[PATCH] D105703: [hwasan] Use stack safety analysis.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. fmayer marked 4 inline comments as done. Closed by commit rGbde9415fef25: [hwasan] Use stack safety analysis. (authored by fmayer). Changed prior to commit: https://

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 360735. fmayer added a comment. formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/hwasan-stac

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka accepted this revision. vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:409 +// analysis. +// This is so we don't need to plumb TargetTriple all the way to here. +if (mightUseStackSafetyAnalysis(Disab

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:410 +Dummy.setArch(Triple::aarch64); +if (shouldUseStackSafetyAnalysis(Dummy, DisableOptimization)) + AU.addRequired(); fmayer wrote: > vitalybuka wr

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 360623. fmayer added a comment. more flag parsing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/hwas

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:410 +Dummy.setArch(Triple::aarch64); +if (shouldUseStackSafetyAnalysis(Dummy, DisableOptimization)) + AU.addRequired(); vitalybuka wrote: > Why not j

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:410 +Dummy.setArch(Triple::aarch64); +if (shouldUseStackSafetyAnalysis(Dummy, DisableOptimization)) + AU.addRequired(); Why not just: ``` if (!Di

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:406 +// architecture that doesn't allow stack tagging we will still load the +// analysis. +// This is so we don't need to plumb TargetTriple all the way to here.

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer added a comment. This broke https://lab.llvm.org/buildbot/#/builders/105/builds/12584. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 ___ cfe-commits ma

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:406 +// architecture that doesn't allow stack tagging we will still load the +// analysis. +// This is so we don't need to plumb TargetTriple all the way to here.

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 360076. fmayer added a comment. fix required analysis logic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/Cod

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer reopened this revision. fmayer added a comment. This revision is now accepted and ready to land. Made some buildbot unhappy again. Sorry :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 _

[PATCH] D105703: [hwasan] Use stack safety analysis.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe9c63ed10b3b: [hwasan] Use stack safety analysis. (authored by fmayer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 360054. fmayer marked an inline comment as done. fmayer added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.

[PATCH] D105703: [hwasan] Use stack safety analysis.

eugenis accepted this revision. eugenis added a comment. In D105703#2887005 , @fmayer wrote: > I removed the stack-safety-analysis-asm.c test because I don't think it > really adds anything and it caused problems. SGTY? Absolutely. LGTM Repository:

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer added a comment. I removed the stack-safety-analysis-asm.c test because I don't think it really adds anything and it caused problems. SGTY? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 359749. fmayer added a comment. remove stack safety asm test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/C

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer reopened this revision. fmayer added a comment. This revision is now accepted and ready to land. Broke some postsubmit bot. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 _

[PATCH] D105703: [hwasan] Use stack safety analysis.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG12268fe14a1a: [hwasan] Use stack safety analysis. (authored by fmayer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 359726. fmayer added a comment. rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/hwasan-stack-sa

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer added inline comments. Comment at: llvm/test/Instrumentation/HWAddressSanitizer/stack-safety-analysis.ll:27 + +attributes #0 = { mustprogress nofree nounwind uwtable willreturn "frame-pointer"="non-leaf" "min-legal-vector-width"="0" "no-trapping-math"="true" "stack-prot

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 359716. fmayer added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/hwasan-stack-saf

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 359715. fmayer added a comment. style fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/hwasan-stack-

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 359714. fmayer marked 6 inline comments as done. fmayer added a comment. improve test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/Backe

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:427 + bool DisableOptimization) { assert(!CompileKernel || Recover); + return new HWAddressSanitizerLegacyPass(CompileKernel, R

[PATCH] D105703: [hwasan] Use stack safety analysis.

eugenis added a comment. In D105703#2884056 , @vitalybuka wrote: > In D105703#2883666 , @eugenis wrote: > >> Btw Vitaly, will this work with LTO out of the box? I think we used to add >> pre-LTO StackSafety pass

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka added a comment. In D105703#2883666 , @eugenis wrote: > Btw Vitaly, will this work with LTO out of the box? I think we used to add > pre-LTO StackSafety pass explicitly for memtag only, but it looks like that > code is gone. What do you mean

[PATCH] D105703: [hwasan] Use stack safety analysis.

eugenis added a comment. Btw Vitaly, will this work with LTO out of the box? I think we used to add pre-LTO StackSafety pass explicitly for memtag only, but it looks like that code is gone. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 359376. fmayer marked 3 inline comments as done. fmayer added a comment. fix comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/Backen

[PATCH] D105703: [hwasan] Use stack safety analysis.

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/CodeGen/BackendUtil.cpp:1174 +CompileKernel, Recover, +/*IsOptNull=*/CodeGenOpts.OptimizationLevel == 0)); } -

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 359373. fmayer added a comment. don't use stack analysis for opt null Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp clan

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:407 bool Recover; + bool DisableOptimization; }; fmayer wrote: > eugenis wrote: > > No need to pass this down, just look at OptimizeNone function attribute.

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer marked 2 inline comments as done. fmayer added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:407 bool Recover; + bool DisableOptimization; }; eugenis wrote: > No need to pass this down, just look at OptimizeNo

[PATCH] D105703: [hwasan] Use stack safety analysis.

eugenis added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:407 bool Recover; + bool DisableOptimization; }; No need to pass this down, just look at OptimizeNone function attribute. Repository: rG LLVM Github Mon

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer marked 3 inline comments as done. fmayer added inline comments. Comment at: llvm/test/CodeGen/hwasan-stack-safety-analysis-asm.c:1 +// RUN: %clang -fsanitize=hwaddress -target aarch64-linux-gnu -S -mllvm -hwasan-use-stack-safety=true -mllvm -hwasan-generate-tags-with-call

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 359326. fmayer added a comment. add llvm test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/hwasan-st

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 359263. fmayer added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/hwasan-stack-saf

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer added inline comments. Comment at: llvm/include/llvm/Transforms/Instrumentation/HWAddressSanitizer.h:32 + Triple TargetTriple = {}); PreservedAnalyses run(Module &M, ModuleAnalysisManager &MAM); static bool isRequired() { return true;

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka added a comment. Please create *.ll tests, the rest is LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 ___ cfe-commits mailing list cfe-commits@

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka added inline comments. Comment at: llvm/include/llvm/Transforms/Instrumentation/HWAddressSanitizer.h:32 + Triple TargetTriple = {}); PreservedAnalyses run(Module &M, ModuleAnalysisManager &MAM); static bool isRequired() { return t

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka updated this revision to Diff 359154. vitalybuka added a comment. Remove triple Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/h

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka added inline comments. Comment at: llvm/test/CodeGen/hwasan-stack-safety-analysis-asm.c:8 + +int main(int argc, char **argv) { + char buf[10]; these tests do not work because %clang is not defined here, in LLVM you can keep them but they need to stay

[PATCH] D105703: [hwasan] Use stack safety analysis.

eugenis added inline comments. Comment at: llvm/test/CodeGen/hwasan-stack-safety-analysis-asm.c:1 +// RUN: %clang -fsanitize=hwaddress -target aarch64-linux-gnu -S -mllvm -hwasan-use-stack-safety=true -mllvm -hwasan-generate-tags-with-calls -O2 %s -o - | FileCheck %s --check-pr

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 358885. fmayer added a comment. fixup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/include/llvm/Transforms/Instrum

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer added a comment. Thanks! Comment at: clang/test/CodeGen/hwasan-stack-safety-analysis-asm.c:4 + +int main(int argc, char **argv) { + char buf[10]; vitalybuka wrote: > fmayer wrote: > > vitalybuka wrote: > > > this patch mostly change code under llvm/ so

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 358884. fmayer marked 7 inline comments as done. fmayer added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/Ba

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka added a comment. Other than missing llvm test is LGTM Comment at: clang/test/CodeGen/hwasan-stack-safety-analysis-asm.c:4 + +int main(int argc, char **argv) { + char buf[10]; fmayer wrote: > vitalybuka wrote: > > this patch mostly change code under

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 358579. fmayer marked an inline comment as done. fmayer added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer marked an inline comment as done and an inline comment as not done. fmayer added a comment. Addressed inline comments. Comment at: clang/test/CodeGen/hwasan-stack-safety-analysis-asm.c:4 + +int main(int argc, char **argv) { + char buf[10]; vitalybuka wr

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 358577. fmayer added a comment. fixup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/hwasan-stack-safe

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 358567. fmayer added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/hwasan-stack-saf

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 358565. fmayer added a comment. fixup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/hwasan-stack-safe

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 358564. fmayer marked 2 inline comments as done. fmayer added a comment. Address some comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/Code

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka added inline comments. Comment at: clang/test/CodeGen/hwasan-stack-safety-analysis-asm.c:4 + +int main(int argc, char **argv) { + char buf[10]; this patch mostly change code under llvm/ so tests should be also there, as IR tests

[PATCH] D105703: [hwasan] Use stack safety analysis.

eugenis added a comment. The analysis should not run at -O0. Otherwise, LGTM. What kind of code size improvement do you see? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 ___

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 358043. fmayer added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/hwasan-stack-saf

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer created this revision. Herald added subscribers: ormris, hiraditya. fmayer updated this revision to Diff 357514. fmayer added a comment. fmayer edited the summary of this revision. fmayer updated this revision to Diff 357544. fmayer edited the summary of this revision. fmayer updated this re