[PATCH] D105692: [analyzer][solver][NFC] Introduce ConstraintAssignor

uabelho added a comment. In D105692#2879983 , @martong wrote: > In D105692#2879186 , @uabelho wrote: > >> Hi, >> >> When compiling with gcc I see the following new warnings with this patch: >> >> [4/22] Building

[PATCH] D105692: [analyzer][solver][NFC] Introduce ConstraintAssignor

martong added a comment. In D105692#2879186 , @uabelho wrote: > Hi, > > When compiling with gcc I see the following new warnings with this patch: > > [4/22] Building CXX object > tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCor

[PATCH] D105692: [analyzer][solver][NFC] Introduce ConstraintAssignor

uabelho added a comment. Hi, When compiling with gcc I see the following new warnings with this patch: [4/22] Building CXX object tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCore.dir/RangeConstraintManager.cpp.o /repo/uabelho/master-github/clang/lib/StaticAnalyzer

[PATCH] D105692: [analyzer][solver][NFC] Introduce ConstraintAssignor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf26deb4e6ba7: [analyzer][solver][NFC] Introduce ConstraintAssignor (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D105692: [analyzer][solver][NFC] Introduce ConstraintAssignor

vsavchenko updated this revision to Diff 358336. vsavchenko added a comment. Fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105692/new/ https://reviews.llvm.org/D105692 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp

[PATCH] D105692: [analyzer][solver][NFC] Introduce ConstraintAssignor

martong added a comment. Uhh, what the hell happened with the `Stack`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105692/new/ https://reviews.llvm.org/D105692 ___ cfe-commits mailing list cfe-commits@

[PATCH] D105692: [analyzer][solver][NFC] Introduce ConstraintAssignor

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1388 +//===--===// +//New constraint handler +//===--

[PATCH] D105692: [analyzer][solver][NFC] Introduce ConstraintAssignor

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Generally it looks okay to me. However, I have a question: In `SimpleSValBuilder::evalBinOpNN` we do infer values to symbols. E.g. if we have an expression `y / x` and `y` is known to be `0`

[PATCH] D105692: [analyzer][solver][NFC] Introduce ConstraintAssignor

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, martong, steakhal, Szelethus, ASDenysPetrov, manas, RedDocMD. Herald added subscribers: dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this revision.