[PATCH] D105679: [clangd] Add CMake option to (not) link in clang-tidy checks

thakis added a comment. Nit: I find the name a bit confusing. When I first saw this commit, I thought this would be a list of clang-tidy checks to support, not a binary on/off toggle. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105679/new/ http

[PATCH] D105679: [clangd] Add CMake option to (not) link in clang-tidy checks

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG462d4de35b0c: [clangd] Add CMake option to (not) link in clang-tidy checks (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D105679?

[PATCH] D105679: [clangd] Add CMake option to (not) link in clang-tidy checks

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:259 +class T{$explicit[[]]$constructor[[T]](int a);}; + sammccall

[PATCH] D105679: [clangd] Add CMake option to (not) link in clang-tidy checks

sammccall updated this revision to Diff 358241. sammccall marked 3 inline comments as done. sammccall added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105679/new/ https://reviews.llvm.org/D105679 Files: clan

[PATCH] D105679: [clangd] Add CMake option to (not) link in clang-tidy checks

sammccall marked 5 inline comments as done. sammccall added a comment. In D105679#2873109 , @nridge wrote: > Will building with this option just prevent linking the clang-tidy checks > into clangd, or will it also prevent building them in the first place

[PATCH] D105679: [clangd] Add CMake option to (not) link in clang-tidy checks

nridge added a comment. Will building with this option just prevent linking the clang-tidy checks into clangd, or will it also prevent building them in the first place? In my experience, it's the building that's the primary compile time expense, so if the intention is to address https://github.

[PATCH] D105679: [clangd] Add CMake option to (not) link in clang-tidy checks

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/ConfigCompileTests.cpp:280 +#if CLANGD_TIDY_CHECKS TEST_F(ConfigCompileTests, Tidy) { why do we need to disable this test? it doesn't really build an ast or assert on the diagnosti

[PATCH] D105679: [clangd] Add CMake option to (not) link in clang-tidy checks

sammccall created this revision. sammccall added reviewers: kadircet, nridge. Herald added subscribers: usaxena95, arphaman, mgorny. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This reduces t