[PATCH] D105526: opencl-c.h: CL3.0 generic address space

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGde79ba9f9a2d: [OpenCL] opencl-c.h: CL3.0 generic address space (authored by airlied). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D105526: opencl-c.h: CL3.0 generic address space

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! PS this patch is straightforward and doesn't seem to affect functionality for older standards provided that we set `__opencl_c_generic_address_space` correctly which is no

[PATCH] D105526: opencl-c.h: CL3.0 generic address space

airlied updated this revision to Diff 358005. airlied added a comment. full diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105526/new/ https://reviews.llvm.org/D105526 Files: clang/lib/Headers/opencl-c.h Index: clang/lib/Headers/opencl-c.h ==

[PATCH] D105526: opencl-c.h: CL3.0 generic address space

Anastasia added a comment. In D105526#2863386 , @airlied wrote: > I've dropped the __SPIR__ change in the base header until things are resolved > for library SPIR users to disable extension defines. Makes sense! But this is not a full diff again. Would

[PATCH] D105526: opencl-c.h: CL3.0 generic address space

airlied updated this revision to Diff 357100. airlied added a comment. I've dropped the __SPIR__ change in the base header until things are resolved for library SPIR users to disable extension defines. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105526/new/ https://reviews.llvm.org/D

[PATCH] D105526: opencl-c.h: CL3.0 generic address space

airlied added inline comments. Comment at: clang/lib/Headers/opencl-c.h:7341 half8 __ovld fract(half8 x, __private half8 *iptr); half16 __ovld fract(half16 x, __private half16 *iptr); Anastasia wrote: > This one is not generic address space pointer though but I

[PATCH] D105526: opencl-c.h: CL3.0 generic address space

airlied updated this revision to Diff 356992. airlied added a comment. updated to full diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105526/new/ https://reviews.llvm.org/D105526 Files: clang/lib/Headers/opencl-c-base.h clang/lib/Headers/opencl-c.h Index: clang/lib/Headers/op

[PATCH] D105526: opencl-c.h: CL3.0 generic address space

Anastasia added inline comments. Comment at: clang/lib/Headers/opencl-c.h:7341 half8 __ovld fract(half8 x, __private half8 *iptr); half16 __ovld fract(half16 x, __private half16 *iptr); This one is not generic address space pointer though but I think this bit i