[PATCH] D105498: [clang] Remove assumption about SourceLocation alignment.

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D105498: [clang] Remove assumption about SourceLocation alignment.

simon_tatham added inline comments. Comment at: clang/include/clang/AST/DeclObjC.h:208 const ParmVarDecl *const *getParams() const { -return reinterpret_cast(ParamsAndSelLocs); +return const_cast(Params); } simon_tatham wrote: > tmatheson wrote: > >

[PATCH] D105498: [clang] Remove assumption about SourceLocation alignment.

simon_tatham updated this revision to Diff 360123. simon_tatham added a comment. Addressed two nits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105498/new/ https://reviews.llvm.org/D105498 Files: clang/include/clang/AST/DeclObjC.h clang/lib

[PATCH] D105498: [clang] Remove assumption about SourceLocation alignment.

simon_tatham added inline comments. Comment at: clang/include/clang/AST/DeclObjC.h:208 const ParmVarDecl *const *getParams() const { -return reinterpret_cast(ParamsAndSelLocs); +return const_cast(Params); } tmatheson wrote: > I don't think you need

[PATCH] D105498: [clang] Remove assumption about SourceLocation alignment.

tmatheson accepted this revision. tmatheson added a subscriber: efriedma. tmatheson added a comment. This revision is now accepted and ready to land. LGTM, but it would be good to have someone else comment on the increased number of allocations (maybe @rsmith or @efriedma?) Co

[PATCH] D105498: [clang] Remove assumption about SourceLocation alignment.

simon_tatham added inline comments. Comment at: clang/lib/AST/DeclObjC.cpp:31 #include "llvm/Support/ErrorHandling.h" +#include "llvm/Support/MathExtras.h" #include "llvm/Support/raw_ostream.h" Oops, before anyone else points it out, this `#include` is also now

[PATCH] D105498: [clang] Remove assumption about SourceLocation alignment.

simon_tatham updated this revision to Diff 360104. simon_tatham added a comment. ... and removed an unused function from the previous version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105498/new/ https://reviews.llvm.org/D105498 Files: clan

[PATCH] D105498: [clang] Remove assumption about SourceLocation alignment.

simon_tatham updated this revision to Diff 360101. simon_tatham edited the summary of this revision. simon_tatham added a comment. Split up the allocations as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105498/new/ https://reviews.llvm

[PATCH] D105498: [clang] Remove assumption about SourceLocation alignment.

tmatheson added inline comments. Comment at: clang/lib/AST/DeclObjC.cpp:880-882 - unsigned Size = sizeof(ParmVarDecl *) * NumParams + - sizeof(SourceLocation) * SelLocs.size(); ParamsAndSelLocs = C.Allocate(Size); Since we know the number of

[PATCH] D105498: [clang] Remove assumption about SourceLocation alignment.

simon_tatham created this revision. simon_tatham added reviewers: rsmith, lebedev.ri, akyrtzi. simon_tatham requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is part of a patch series working towards the ability to make SourceLocation in