This revision was automatically updated to reflect the committed changes.
Closed by commit rG1b52e9bac207: [AIX] Define __LONGDOUBLE64 macro (authored by
Jake-Egan).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105477/new/
https://reviews.llvm.org/
cebowleratibm added a comment.
The decision was made to make -mlong-double-128 an error on AIX:
https://reviews.llvm.org/D106074 [AIX] Clang's library integration support for
128-bit long double is incomplete on AIX.
So I think your patch is ready to land. LGTM.
Repository:
rG LLVM Github
cebowleratibm accepted this revision.
cebowleratibm added a comment.
This revision is now accepted and ready to land.
The change made me think we should add the negative test with
-mlong-double-128, but then I thought we should probably make that an error
until we've sorted through the AIX binar
Jake-Egan updated this revision to Diff 357399.
Jake-Egan added a comment.
Add control by -mlong-double-64 option.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105477/new/
https://reviews.llvm.org/D105477
Files:
clang/lib/Basic/Targets/PPC.cpp
cebowleratibm requested changes to this revision.
cebowleratibm added inline comments.
This revision now requires changes to proceed.
Comment at: clang/lib/Basic/Targets/PPC.cpp:175
+ if (getTriple().isOSAIX() && LongDoubleWidth == 64) {
+Builder.defineMacro("__LONGDOUBLE6
