This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGde3956605a70: [PowerPC] Fix popcntb XL Compat Builtin for
32bit (authored by quinnp, committed by kamaub).
Changed prior to commit:
https://review
nemanjai added inline comments.
Comment at: llvm/lib/Target/PowerPC/PPCInstr64Bit.td:831
+// 64bit version of popcntb for 64bit sized unsigned long.
+let isCodeGenOnly = 1 in
+def POPCNTB8 : XForm_11<31, 122, (outs g8rc:$rA), (ins g8rc:$rS),
efriedma wrote:
> ne
efriedma added inline comments.
Comment at: llvm/lib/Target/PowerPC/PPCInstr64Bit.td:831
+// 64bit version of popcntb for 64bit sized unsigned long.
+let isCodeGenOnly = 1 in
+def POPCNTB8 : XForm_11<31, 122, (outs g8rc:$rA), (ins g8rc:$rS),
nemanjai wrote:
> ef
nemanjai added inline comments.
Comment at: llvm/lib/Target/PowerPC/PPCInstr64Bit.td:831
+// 64bit version of popcntb for 64bit sized unsigned long.
+let isCodeGenOnly = 1 in
+def POPCNTB8 : XForm_11<31, 122, (outs g8rc:$rA), (ins g8rc:$rS),
efriedma wrote:
> I'
quinnp updated this revision to Diff 358639.
quinnp added a comment.
Removing another comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105360/new/
https://reviews.llvm.org/D105360
Files:
clang/lib/CodeGen/CGBuiltin.cpp
clang/test/CodeGen
quinnp updated this revision to Diff 358637.
quinnp added a comment.
Removing a misleading comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105360/new/
https://reviews.llvm.org/D105360
Files:
clang/lib/CodeGen/CGBuiltin.cpp
clang/test/Co
quinnp updated this revision to Diff 358609.
quinnp marked 9 inline comments as done.
quinnp added a comment.
Addressing review comment about indentation.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105360/new/
https://reviews.llvm.org/D105360
F
efriedma added inline comments.
Comment at: llvm/lib/Target/PowerPC/PPCInstr64Bit.td:831
+// 64bit version of popcntb for 64bit sized unsigned long.
+let isCodeGenOnly = 1 in
+def POPCNTB8 : XForm_11<31, 122, (outs g8rc:$rA), (ins g8rc:$rS),
I'm sort of confused
amyk accepted this revision.
amyk added a comment.
Minor indentation comments but LGTM.
Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-sync.c:3
// RUN: %clang_cc1 -triple powerpc64-unknown-unknown \
-// RUN:-emit-llvm %s -o - -target-cpu pwr8 | FileCheck %s
+// RUN:
nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105360/new/
https://reviews.llvm.org/D105360
__
quinnp updated this revision to Diff 356719.
quinnp added a comment.
Addressing review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105360/new/
https://reviews.llvm.org/D105360
Files:
clang/lib/CodeGen/CGBuiltin.cpp
clang/test/CodeG
NeHuang added inline comments.
Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-sync.c:240
+void test_icbt() {
+ __icbt(c);
}
From the document, `__icbt` only valid when -qarch is set to target pwr8 or
higher processors. It looks like target cpu sema check
amyk added inline comments.
Comment at: llvm/lib/Target/PowerPC/PPCInstr64Bit.td:830
-def POPCNTB : XForm_11<31, 122, (outs g8rc:$rA), (ins g8rc:$rS),
- "popcntb $rA, $rS", IIC_IntGeneral,
- [(set i64:$rA, (int_ppc_popcntb i64:$rS))]>
quinnp created this revision.
Herald added subscribers: shchenz, kbarton, hiraditya, nemanjai.
quinnp requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D105360
14 matches
Mail list logo
