[PATCH] D105331: [CFE][X86] Enable complex _Float16 support

This revision was automatically updated to reflect the committed changes. Closed by commit rG5aeca3b0a595: [CFE][X86] Enable complex _Float16 support (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105331/new/ https://reviews.ll

[PATCH] D105331: [CFE][X86] Enable complex _Float16 support

LuoYuanke accepted this revision. LuoYuanke added a comment. This revision is now accepted and ready to land. LGTM, but wait 1 or 2 days to see if there is any comments from others. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105331/new/ https://

[PATCH] D105331: [CFE][X86] Enable complex _Float16.

LuoYuanke added a comment. Could you add the linkage of ABI in the commit message? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105331/new/ https://reviews.llvm.org/D105331 ___ cfe-commits mailing list

[PATCH] D105331: [CFE][X86] Enable complex _Float16.

pengfei updated this revision to Diff 365360. pengfei added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105331/new/ https://reviews.llvm.org/D105331 Files: clang/lib/CodeGen/TargetInfo.cpp clang/lib/Sema/DeclSpec.cpp cl

[PATCH] D105331: [CFE][X86] Enable complex _Float16.

pengfei added a comment. In D105331#2933893 , @LuoYuanke wrote: > Would you check the failure of the test cases? They failed due to they are built based on the ToT instead of the 1st patch of FP16. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D105331: [CFE][X86] Enable complex _Float16.

LuoYuanke added a comment. Would you check the failure of the test cases? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105331/new/ https://reviews.llvm.org/D105331 ___ cfe-commits mailing list cfe-commi

[PATCH] D105331: [CFE][X86] Enable complex _Float16.

pengfei added a comment. In D105331#2854934 , @SjoerdMeijer wrote: > The patch on itself looks reasonable to me. I was just wondering about the > _Float16 support on X86 in general because the Clang docs says: > > _Float16 is currently only supported

[PATCH] D105331: [CFE][X86] Enable complex _Float16.

SjoerdMeijer added a comment. The patch on itself looks reasonable to me. I was just wondering about the _Float16 support on X86 in general because the Clang docs says: _Float16 is currently only supported on the following targets, with further targets pending ABI standardization: Does X86

[PATCH] D105331: [CFE][X86] Enable complex _Float16.

pengfei created this revision. pengfei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D105331 Files: clang/lib/CodeGen/TargetInfo.cpp clang/lib/Sema/DeclSpec.cpp clang/