[PATCH] D105295: [CUDA] Only allow NVIDIA offload-arch during CUDA compilation.

2021-07-13 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. In D105295#2874935 , @tra wrote: > Ugh. I broke the cuda-bad-arch.cu test. Should be fixed in 25629bb45f0a4b8c8e99dbde4f4a7e3d980b9fd7 Repository: rG LLVM Git

[PATCH] D105295: [CUDA] Only allow NVIDIA offload-arch during CUDA compilation.

2021-07-13 Thread Douglas Yung via Phabricator via cfe-commits
dyung added a comment. I think your change also broke cuda-flush-denormals-to-zero.cu: https://lab.llvm.org/buildbot/#/builders/139/builds/7048 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105295/new/ https://reviews.llvm.org/D105295 ___

[PATCH] D105295: [CUDA] Only allow NVIDIA offload-arch during CUDA compilation.

2021-07-13 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. Ugh. I broke the cuda-bad-arch.cu test. Comment at: clang/test/Driver/cuda-bad-arch.cu:30 // RUN: | FileCheck -check-prefix OK %s // RUN: %clang -### -target x86_64-linux-gnu --cuda-gpu-arch=gfx90a -c %s 2>&1 \ // RUN: | FileCheck -check-prefix OK %s --

[PATCH] D105295: [CUDA] Only allow NVIDIA offload-arch during CUDA compilation.

2021-07-13 Thread Artem Belevich via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG01d3a3dcabaf: [CUDA] Only allow NVIDIA offload-arch during CUDA compilation. (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D105295: [CUDA] Only allow NVIDIA offload-arch during CUDA compilation.

2021-07-06 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105295/new/ https://reviews.llvm.org/D105295 __

[PATCH] D105295: [CUDA] Only allow NVIDIA offload-arch during CUDA compilation.

2021-07-01 Thread Artem Belevich via Phabricator via cfe-commits
tra created this revision. tra added a reviewer: yaxunl. Herald added a subscriber: bixia. tra requested review of this revision. Herald added a project: clang. Otherwise, if someone specifies a valid AMD arch, we may end up triggering an assertion on unexpected arch later on. Current tests didn'