This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc728bd5bbaab: [X86] AVX512FP16 instructions enabling 5/6
(authored by pengfei).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
h
LuoYuanke accepted this revision.
LuoYuanke added a comment.
This revision is now accepted and ready to land.
LGTM, may wait 1 or 2 days for comments from others.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105268/new/
https://reviews.llvm.org/D1
pengfei added inline comments.
Comment at: clang/include/clang/Basic/BuiltinsX86.def:2010
+TARGET_BUILTIN(__builtin_ia32_vfmaddph, "V8xV8xV8xV8x", "ncV:128:",
"avx512fp16,avx512vl")
+TARGET_BUILTIN(__builtin_ia32_vfmaddph256, "V16xV16xV16xV16x", "ncV:256:",
"avx512fp16,avx512vl
pengfei updated this revision to Diff 367957.
pengfei marked 8 inline comments as done.
pengfei added a comment.
Address Yuanke's comments. Thanks Yuanke and Craig.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105268/new/
https://reviews.llvm.org/
LuoYuanke added a comment.
I understand now. Thanks, Craig.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105268/new/
https://reviews.llvm.org/D105268
___
cfe-commits mailing list
cfe-commits@lists.llvm.
craig.topper added inline comments.
Comment at: clang/include/clang/Basic/BuiltinsX86.def:2014
+
+TARGET_BUILTIN(__builtin_ia32_vfmaddsh3_mask, "V8xV8xV8xV8xUcIi", "ncV:128:",
"avx512fp16")
+TARGET_BUILTIN(__builtin_ia32_vfmaddsh3_maskz, "V8xV8xV8xV8xUcIi", "ncV:128:",
"avx512f
LuoYuanke added inline comments.
Comment at: clang/include/clang/Basic/BuiltinsX86.def:2010
+TARGET_BUILTIN(__builtin_ia32_vfmaddph, "V8xV8xV8xV8x", "ncV:128:",
"avx512fp16,avx512vl")
+TARGET_BUILTIN(__builtin_ia32_vfmaddph256, "V16xV16xV16xV16x", "ncV:256:",
"avx512fp16,avx512
pengfei added inline comments.
Comment at: clang/lib/Headers/avx512fp16intrin.h:2373
+ (__v32hf)(__m512h)(A), (__v32hf)(__m512h)(B), (__v32hf)(__m512h)(C),
\
+ (__mmask32)-1, (int)(R))
+
RKSimon wrote:
> Add outer brackets to all the defines to pre
pengfei updated this revision to Diff 366873.
pengfei added a comment.
Rebased.
Add extra parentheses for macro.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105268/new/
https://reviews.llvm.org/D105268
Files:
clang/include/clang/Basic/Builtins
RKSimon added inline comments.
Comment at: clang/lib/Headers/avx512fp16intrin.h:2373
+ (__v32hf)(__m512h)(A), (__v32hf)(__m512h)(B), (__v32hf)(__m512h)(C),
\
+ (__mmask32)-1, (int)(R))
+
Add outer brackets to all the defines to prevent precedence i
pengfei updated this revision to Diff 356585.
pengfei added a comment.
Fix the capitalization mismatch in tests. Thanks Sanjay!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105268/new/
https://reviews.llvm.org/D105268
Files:
clang/include/clang
pengfei added inline comments.
Comment at: llvm/test/CodeGen/X86/stack-folding-fp-avx512fp16vl-fma.ll:193-194
+define <8 x half> @stack_fold_fmsub123ph(<8 x half> %a0, <8 x half> %a1, <8 x
half> %a2) {
+ ;check-label: stack_fold_fmsub123ph:
+ ;check: vfmsub213ph {{-?[0-9
spatel added inline comments.
Comment at: llvm/test/CodeGen/X86/stack-folding-fp-avx512fp16vl-fma.ll:193-194
+define <8 x half> @stack_fold_fmsub123ph(<8 x half> %a0, <8 x half> %a1, <8 x
half> %a2) {
+ ;check-label: stack_fold_fmsub123ph:
+ ;check: vfmsub213ph {{-?[0-9]
pengfei created this revision.
pengfei added reviewers: craig.topper, RKSimon, spatel, LiuChen3, FreddyYe,
yubing, LuoYuanke.
Herald added a subscriber: hiraditya.
pengfei requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
E
14 matches
Mail list logo
