[PATCH] D105265: [X86] AVX512FP16 instructions enabling 3/6

pengfei added a comment. In D105265#2955329 , @vitalybuka wrote: > I suspect this error from this or D105331 > https://lab.llvm.org/buildbot/#/builders/85/builds/6132 Thanks @vitalybuka for the information. I didn't re

[PATCH] D105265: [X86] AVX512FP16 instructions enabling 3/6

vitalybuka added a subscriber: kstoimenov. vitalybuka added a comment. FYI @kstoimenov Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105265/new/ https://reviews.llvm.org/D105265 ___ cfe-commits mailing l

[PATCH] D105265: [X86] AVX512FP16 instructions enabling 3/6

vitalybuka added a comment. I suspect this error from this or D105331 https://lab.llvm.org/buildbot/#/builders/85/builds/6132 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105265/new/ https://reviews.llvm.org/D105

[PATCH] D105265: [X86] AVX512FP16 instructions enabling 3/6

samitolvanen added a comment. FYI, this breaks the Linux kernel when built with ThinLTO: https://github.com/ClangBuiltLinux/linux/issues/1440 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105265/new/ https://reviews.llvm.org/D105265 _

[PATCH] D105265: [X86] AVX512FP16 instructions enabling 3/6

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2379949aadce: [X86] AVX512FP16 instructions enabling 3/6 (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D105265: [X86] AVX512FP16 instructions enabling 3/6

LuoYuanke accepted this revision. LuoYuanke added a comment. This revision is now accepted and ready to land. LGTM, but wait 1 or 2 days for the comments from others. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105265/new/ https://reviews.llvm.or

[PATCH] D105265: [X86] AVX512FP16 instructions enabling 3/6

pengfei added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:1996 setOperationAction(ISD::SCALAR_TO_VECTOR, MVT::v16f16, Custom); + setOperationAction(ISD::SINT_TO_FP, MVT::v16i16, Legal); + setOperationAction(ISD::STRICT_SINT_TO_F

[PATCH] D105265: [X86] AVX512FP16 instructions enabling 3/6

pengfei added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:1996 setOperationAction(ISD::SCALAR_TO_VECTOR, MVT::v16f16, Custom); + setOperationAction(ISD::SINT_TO_FP, MVT::v16i16, Legal); + setOperationAction(ISD::STRICT_SINT_TO_F

[PATCH] D105265: [X86] AVX512FP16 instructions enabling 3/6

pengfei updated this revision to Diff 366630. pengfei added a comment. 1. Address Yuanke's comments. 2. Add missed strict FP handling. 3. Refactor the repeated declarations for strict FP. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105265/new/ ht

[PATCH] D105265: [X86] AVX512FP16 instructions enabling 3/6

LuoYuanke added a comment. Thank Craig for the clarification! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105265/new/ https://reviews.llvm.org/D105265 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D105265: [X86] AVX512FP16 instructions enabling 3/6

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:31087 +// Now widen to 128 bits. +unsigned NumConcats = 128 / TmpVT.getSizeInBits(); +MVT ConcatVT = MVT::getVectorVT(EleVT.getSimpleVT(), 8 * NumConcats);

[PATCH] D105265: [X86] AVX512FP16 instructions enabling 3/6

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:1955 setOperationAction(ISD::SCALAR_TO_VECTOR, MVT::v32f16, Custom); + setOperationAction(ISD::SINT_TO_FP, MVT::v32i16, Legal); + setOperationAction(ISD::STR

[PATCH] D105265: [X86] AVX512FP16 instructions enabling 3/6

LuoYuanke added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:1955 setOperationAction(ISD::SCALAR_TO_VECTOR, MVT::v32f16, Custom); + setOperationAction(ISD::SINT_TO_FP, MVT::v32i16, Legal); + setOperationAction(ISD::STRICT

[PATCH] D105265: [X86] AVX512FP16 instructions enabling 3/6

pengfei updated this revision to Diff 366470. pengfei marked an inline comment as done. pengfei added a comment. Rebased. Add extra parentheses for macro. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105265/new/ https://reviews.llvm.org/D105265 F

[PATCH] D105265: [X86] AVX512FP16 instructions enabling 3/6

craig.topper added inline comments. Comment at: clang/lib/Headers/avx512fp16intrin.h:953 +#define _mm512_cvt_roundpd_ph(A, R) \ + (__m128h) __builtin_ia32_vcvtpd2ph512_mask( \ + (__v8df)(A), (__v8

[PATCH] D105265: [X86] AVX512FP16 instructions enabling 3/6

pengfei added inline comments. Comment at: clang/lib/Headers/avx512fp16intrin.h:1748 + +#define _mm_cvt_roundsh_i32(A, R) \ + (int)__builtin_ia32_vcvtsh2si32((__v8hf)(A), (int)(R)) LuoYuanke wrote: > Does it also ret

[PATCH] D105265: [X86] AVX512FP16 instructions enabling 3/6

LuoYuanke added inline comments. Comment at: clang/lib/Headers/avx512fp16intrin.h:1748 + +#define _mm_cvt_roundsh_i32(A, R) \ + (int)__builtin_ia32_vcvtsh2si32((__v8hf)(A), (int)(R)) Does it also return i32 in x86_64

[PATCH] D105265: [X86] AVX512FP16 instructions enabling 3/6

pengfei updated this revision to Diff 357722. pengfei added a comment. Add tests for __extendhfxf2 and __truncxfhf2. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105265/new/ https://reviews.llvm.org/D105265 Files: clang/include/clang/Basic/Buil

[PATCH] D105265: [X86] AVX512FP16 instructions enabling 3/6

pengfei updated this revision to Diff 355786. pengfei added a comment. Remove unexpected intrinsics. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105265/new/ https://reviews.llvm.org/D105265 Files: clang/include/clang/Basic/BuiltinsX86.def cl

[PATCH] D105265: [X86] AVX512FP16 instructions enabling 3/6

pengfei created this revision. pengfei added reviewers: craig.topper, RKSimon, spatel, LiuChen3, FreddyYe, yubing, LuoYuanke. Herald added a subscriber: hiraditya. pengfei requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. E