[PATCH] D105254: [RISCV] Support machine constraint "S"

This revision was automatically updated to reflect the committed changes. Closed by commit rG3d89fb4d13bc: [RISCV] Support machine constraint "S" (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D105254?vs=355749&id=358308#toc Repository: rG LLVM Github Monorepo CHAN

[PATCH] D105254: [RISCV] Support machine constraint "S"

jrtc27 added inline comments. Comment at: llvm/test/CodeGen/RISCV/inline-asm-S-constraint.ll:27 + +; Function Attrs: nofree nosync nounwind readnone +define dso_local i8* @constraint_S_label() { Not needed Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D105254: [RISCV] Support machine constraint "S"

kito-cheng added a comment. RISC-V GCC site has update the document for 'S'. https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h=18a463bb666cc8f3421589e7641ec617acb84741 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105254/new/ https://reviews.llvm.org/

[PATCH] D105254: [RISCV] Support machine constraint "S"

MaskRay added a comment. In D105254#2871278 , @luismarques wrote: > In D105254#2852489 , @luismarques > wrote: > >> Makes sense. Let's wait for the GCC Bugzilla feedback. > > With 'S' now documented on the GNU s

[PATCH] D105254: [RISCV] Support machine constraint "S"

luismarques accepted this revision. luismarques added a comment. This revision is now accepted and ready to land. In D105254#2852489 , @luismarques wrote: > Makes sense. Let's wait for the GCC Bugzilla feedback. With 'S' now documented on the GNU side,

[PATCH] D105254: [RISCV] Support machine constraint "S"

luismarques added a comment. Makes sense. Let's wait for the GCC Bugzilla feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105254/new/ https://reviews.llvm.org/D105254 ___ cfe-commits mailing list

[PATCH] D105254: [RISCV] Support machine constraint "S"

MaskRay added a comment. In D105254#2851889 , @jrtc27 wrote: > Hm, AArch64 handles ExternalSymbolSDNode too, but I don't see how you could > ever end up with one... It can't and the code path is untested. I already deleted it from aarch64. Repository:

[PATCH] D105254: [RISCV] Support machine constraint "S"

jrtc27 added inline comments. Comment at: llvm/test/CodeGen/RISCV/inline-asm-S-constraint.ll:24 +; RV64-NEXT:ret +entry: + %0 = tail call i8* asm "lui $0, %hi($1)\0Aaddi $0,$0,%lo($1)", "=r,S"(i32* nonnull @var) MaskRay wrote: > jrtc27 wrote: > > Label isn'

[PATCH] D105254: [RISCV] Support machine constraint "S"

MaskRay added inline comments. Comment at: llvm/test/CodeGen/RISCV/inline-asm-S-constraint.ll:24 +; RV64-NEXT:ret +entry: + %0 = tail call i8* asm "lui $0, %hi($1)\0Aaddi $0,$0,%lo($1)", "=r,S"(i32* nonnull @var) jrtc27 wrote: > Label isn't needed Omitting

[PATCH] D105254: [RISCV] Support machine constraint "S"

MaskRay updated this revision to Diff 355749. MaskRay marked 6 inline comments as done. MaskRay added a comment. scrub labels/comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105254/new/ https://reviews.llvm.org/D105254 Files: clang/lib/Ba

[PATCH] D105254: [RISCV] Support machine constraint "S"

jrtc27 added a comment. Hm, AArch64 handles ExternalSymbolSDNode too, but I don't see how you could ever end up with one... Comment at: llvm/test/CodeGen/RISCV/inline-asm-S-constraint.ll:7 + +; Function Attrs: nofree nosync nounwind readnone +define dso_local i8* @constraint_S

[PATCH] D105254: [RISCV] Support machine constraint "S"

MaskRay created this revision. Herald added subscribers: vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, simoncook, jo