[PATCH] D105236: [PowerPC] Implement Load and Reserve and Store Conditional Builtins

2021-07-09 Thread Nemanja Ivanovic via Phabricator via cfe-commits
nemanjai added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:1533 + def int_ppc_lwarx : GCCBuiltin<"__builtin_ppc_lwarx">, + Intrinsic<[llvm_i32_ty], [llvm_ptr_ty], [IntrNoMem]>; + def int_ppc_ldarx : GCCBuiltin<"__builtin_ppc_ldarx

[PATCH] D105236: [PowerPC] Implement Load and Reserve and Store Conditional Builtins

2021-07-05 Thread Albion Fung via Phabricator via cfe-commits
Conanap added a comment. In D105236#2858909 , @thakis wrote: > Looks like this breaks tests: http://45.33.8.238/linux/50465/step_7.txt > > Please take a look, and revert for now if it takes a while to fix. Hi! I accidentally included a test case meant fo

[PATCH] D105236: [PowerPC] Implement Load and Reserve and Store Conditional Builtins

2021-07-05 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Looks like this breaks tests: http://45.33.8.238/linux/50465/step_7.txt Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105236/new/ https://reviews.llvm.org/D

[PATCH] D105236: [PowerPC] Implement Load and Reserve and Store Conditional Builtins

2021-07-05 Thread Albion Fung via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7d10dd60ce12: [PowerPC] Implament Load and Reserve and Store Conditional Builtins (authored by Conanap). Changed prior to commit: https://reviews.llvm.org/D105236?vs=356562&id=356590#toc Repository:

[PATCH] D105236: [PowerPC] Implement Load and Reserve and Store Conditional Builtins

2021-07-05 Thread Kai Luo via Phabricator via cfe-commits
lkail accepted this revision. lkail added a comment. lgtm,thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105236/new/ https://reviews.llvm.org/D105236 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D105236: [PowerPC] Implement Load and Reserve and Store Conditional Builtins

2021-07-05 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp accepted this revision. stefanp added a comment. Thank you! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105236/new/ https://reviews.llvm.org/D105236 ___ cfe-commits mailing list cfe-commi