[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

pdhaliwal added inline comments. Comment at: clang/test/Driver/fat_archive.cpp:9 +// could be resolved correctly. +// RUN: env LIBRARY_PATH=%T/../../../../../runtimes/runtimes-bins/openmp/libomptarget %clang -O2 -target x86_64-pc-linux-gnu -fopenmp -fopenmp-targets=amdgcn-amd-

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

saiislam added a comment. In D105191#3013955 , @ye-luo wrote: > This patch doesn't seem to break anything on my side. > @saiislam could you > > 1. address all the in-source review comments > 2. update the title to `[Clang][OpenMP] Add partial support for

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

ye-luo added a comment. This patch doesn't seem to break anything on my side. @saiislam could you 1. address all the in-source review comments 2. update the title to `[Clang][OpenMP] Add partial support for Static Device Libraries` 3. update the patch description about what works and what doesn'

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

ye-luo added a comment. > The option of adding sm_XX in Bundle Entry ID when user hasn't used -march > flag, comes under command line simplification. I have a bunch of upcoming > patches which will significantly simplify OpenMP command line for GPU > offloading. But, don't you think this featur

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

JonChesterfield added a comment. In D105191#3001508 , @saiislam wrote: > PS: We (mulit-company OpenMP-dev meetings) have been tracking this feature > for a while and we would very much like it to be picked for llvm-13. I think llvm-13 is on -final now s

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

saiislam added a comment. In D105191#3001056 , @ye-luo wrote: > 1. modf works now. > > 2. if I modify the complile.sh > > clang++ -fopenmp -fopenmp-targets=nvptx64 -c classA.cpp > rm -f libmylib.a > ar qc libmylib.a classA.o > ranlib libmylib.a >

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

ye-luo added a comment. 1. modf works now. 2. if I modify the complile.sh clang++ -fopenmp -fopenmp-targets=nvptx64 -c classA.cpp rm -f libmylib.a ar qc libmylib.a classA.o ranlib libmylib.a clang++ -fopenmp -fopenmp-targets=nvptx64 main.cpp -L. -lmylib ./a.out doesn't work. I think

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

saiislam updated this revision to Diff 372514. saiislam added a comment. Rebase and a minor fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105191/new/ https://reviews.llvm.org/D105191 Files: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp cla

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

ye-luo added a comment. yeluo@epyc-server:~/opt/openmp-target/tests/math$ clang++ -fopenmp -fopenmp-targets=nvptx64 -Xopenmp-target=nvptx64 -march=sm_80 modf.cpp -c yeluo@epyc-server:~/opt/openmp-target/tests/math$ clang-offload-bundler -type=o --inputs=modf.o --list openmp-nvptx64 host-

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

saiislam added a comment. In D105191#2998372 , @ye-luo wrote: > the modf test still doesn't work. The issue was from unbundle. > case 1 works. > > clang++ -fopenmp -fopenmp-targets=nvptx64 modf.cpp -c > clang++ -fopenmp -fopenmp-targets=nvptx64 modf.o

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

ye-luo added a comment. the modf test still doesn't work. The issue was from unbundle. case 1 works. clang++ -fopenmp -fopenmp-targets=nvptx64 modf.cpp -c clang++ -fopenmp -fopenmp-targets=nvptx64 modf.o case 2 clang++ -fopenmp -fopenmp-targets=nvptx64 -Xopenmp-target=nvptx64 -march=sm_8

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

saiislam added a comment. In D105191#2997272 , @ye-luo wrote: > @saiislam did you turn on offload? > https://github.com/ye-luo/openmp-target/wiki/OpenMP-offload-compilers#llvm-clang > On NVIDIA, it fails at CMake step. On AMD, make step stops because of

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

saiislam updated this revision to Diff 372307. saiislam added a comment. Fix for file types in fat archive. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105191/new/ https://reviews.llvm.org/D105191 Files: clang/lib/Driver/ToolChains/AMDGPUOpenM

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

ye-luo added a comment. @saiislam did you turn on offload? https://github.com/ye-luo/openmp-target/wiki/OpenMP-offload-compilers#llvm-clang On NVIDIA, it fails at CMake step. On AMD, make step stops because of unrelated issue. Please make the exact reproducer 1 working. Right now I got $ cla

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

saiislam added a comment. In D105191#2996201 , @ye-luo wrote: > @saiislam do my test cases work on your side? I tried this patch and still > got linking failure. Hey @ye-luo, I am able to successfully compile and run all (36) tests in https://github.co

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

ye-luo added a comment. @saiislam do my test cases work on your side? I tried this patch and still got linking failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105191/new/ https://reviews.llvm.org/D105191 ___

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

saiislam updated this revision to Diff 371946. saiislam marked an inline comment as done. saiislam added a comment. Added documentation and other fixes suggested by reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105191/new/ https://review

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

saiislam added a comment. In D105191#2985819 , @ye-luo wrote: > @saiislam since clang-nvlink-wrapper has landed, could you update this patch? @ye-luo , In the last multi-company OpenMP-dev meeting it was suggested that D106809

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

ye-luo added a comment. @saiislam since clang-nvlink-wrapper has landed, could you update this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105191/new/ https://reviews.llvm.org/D105191 ___ cfe-co

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

ye-luo added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.h:62 + bool postClangLink); +void AddStaticDeviceLibs(Compilation *C, const Tool *T, const JobAction *JA, + const InputInfoList *Inputs, const Driver &

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1599-1618 +// For bitcode SDL, search for these 12 relative SDL filenames +SDLs.push_back( +Twine("/libdevice/libbc-" + Lib + "-" + Arch + "-" + Target + ".a") +.str());

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

saiislam added a comment. In D105191#2910961 , @ye-luo wrote: > Do I must use llvm-ar/ranlib or system ar/ranlib is OK? > > 1. existing use case breaks > > Use https://github.com/ye-luo/openmp-target/blob/master/tests/math/modf.cpp > $ clang++ -fopenmp -

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

ye-luo added a comment. Do I must use llvm-ar/ranlib or system ar/ranlib is OK? 1. existing use case breaks Use https://github.com/ye-luo/openmp-target/blob/master/tests/math/modf.cpp $ clang++ -fopenmp -fopenmp-targets=nvptx64 -Xopenmp-target=nvptx64 -march=sm_80 modf.cpp # still OK $ clang+

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

jdoerfert added a comment. `x64 debian > Clang.Driver::fat_archive.cpp Failed` @ABataev @grokos any comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105191/new/ https://reviews.llvm.org/D105191

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

saiislam updated this revision to Diff 361633. saiislam marked 2 inline comments as done. saiislam added a comment. Added instructions to generate a fat archive and reduced the size of attached libFatArchive.a used for testing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

saiislam marked 5 inline comments as done. saiislam added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7674-7687 +StringRef GPUArchName; +if ((CurKind == Action::OFK_OpenMP)) { + // Extract GPUArch from -march argument in TC argument list. +

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

saiislam updated this revision to Diff 361591. saiislam added a comment. Couple of wrong files got added in the last commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105191/new/ https://reviews.llvm.org/D105191 Files: clang/lib/Driver/ToolC

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

saiislam updated this revision to Diff 361590. saiislam added a comment. Herald added a subscriber: ormris. 1. Simplified the nested loop to look for repeated SDLs. 2. Minimized creation of std::string in favour of StringRef wherever possible. 3. Added test cases Repository: rG LLVM Github Mon

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

jdoerfert added a comment. Tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105191/new/ https://reviews.llvm.org/D105191 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

grokos added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1689 + : "lib" + libname + "-" + archname + "-" + gpuname, + "a"); + "a" --> ".a" (add a dot) Comment at: clang/lib/Driver/ToolC

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

jdoerfert added a comment. Not a thorough review but comments to address. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1662 + std::string archname = ArchName.str(); + std::string gpuname = GPUArch.str(); + Coding convention. Comme

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

saiislam created this revision. saiislam added reviewers: jdoerfert, ABataev, JonChesterfield, grokos. Herald added subscribers: kerbowa, guansong, yaxunl, nhaehnle, jvesely. saiislam requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang.