[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

saiislam marked an inline comment as done. saiislam added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp:120 + /* bitcode SDL?*/ true, + /* PostClang Link? */ false); // Add an intermediate output file. -

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

MyDeveloperDay added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp:120 + /* bitcode SDL?*/ true, + /* PostClang Link? */ false); // Add an intermediate output file. This file now fails clang

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

thakis added a comment. Looks like the test looks for "ld" but Windows prints "\link.exe" -- maybe you need to pass an explicit triple to the compiler? Or relax the check line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105191/new/ https://revi

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

saiislam added a comment. In D105191#3047954 , @thakis wrote: > Fix didn't help, still broken at least on Windows: > http://45.33.8.238/win/46515/step_7.txt Ohk. Reverting this patch in a few minutes. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

thakis added a comment. Fix didn't help, still broken at least on Windows: http://45.33.8.238/win/46515/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105191/new/ https://reviews.llvm.org/D105191

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

saiislam added a comment. In D105191#3047903 , @JonChesterfield wrote: > Blocking windows + osx for a couple of hours is bad, let's revert it. Will do > so myself when I get to a desktop Here is the fix: D111311 Pleas

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

JonChesterfield added a comment. Blocking windows + osx for a couple of hours is bad, let's revert it. Will do so myself when I get to a desktop Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105191/new/ https://reviews.llvm.org/D105191 __

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

thakis added a comment. Here's a failure on an official LLVM buildbot: https://lab.llvm.org/buildbot/#/builders/123/builds/6536 https://lab.llvm.org/buildbot/#/builders/123 has been red for over 8 hours now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

thakis added a comment. Looks like the test is failing on Windows too: http://45.33.8.238/win/46512/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105191/new/ https://reviews.llvm.org/D105191

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

thakis added a comment. It's been broken for a while now. Should we revert this for now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105191/new/ https://reviews.llvm.org/D105191 ___ cfe-commits mailing

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

saiislam added a comment. In D105191#3047596 , @thakis wrote: > Looks like this breaks tests on Mac: http://45.33.8.238/mac/36543/step_7.txt > > Please take a look and revert for now if it takes a while to fix. Thanks for reporting. Taking a look. Repo

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

thakis added a comment. Looks like this breaks tests on Mac: http://45.33.8.238/mac/36543/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105191/new/ https://reviews.llvm.o

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

saiislam added a comment. Fixed windows build bot errors after landing this patch with 06404d5488ea505b00f711393973db3ae32d01e9 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4c4117089599: [Clang][OpenMP] Add partial support for Static Device Libraries (authored by saiislam). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

ye-luo accepted this revision. ye-luo added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105191/new/ https://reviews.llvm.org/D105191 __

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

saiislam updated this revision to Diff 377500. saiislam marked 3 inline comments as done. saiislam added a comment. Function name refactoring for AddStaticDeviceLibs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105191/new/ https://reviews.llvm.or

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

ye-luo added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.h:62 + bool postClangLink); +void AddStaticDeviceLibs(Compilation *C, const Tool *T, const JobAction *JA, + const InputInfoList *Inputs, const Driver &

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

ye-luo added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.h:62 + bool postClangLink); +void AddStaticDeviceLibs(Compilation *C, const Tool *T, const JobAction *JA, + const InputInfoList *Inputs, const Driver &

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

saiislam marked an inline comment as done. saiislam added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.h:62 + bool postClangLink); +void AddStaticDeviceLibs(Compilation *C, const Tool *T, const JobAction *JA, +

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

ye-luo added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.h:62 + bool postClangLink); +void AddStaticDeviceLibs(Compilation *C, const Tool *T, const JobAction *JA, + const InputInfoList *Inputs, const Driver &

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

saiislam added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105191/new/ https://reviews.llvm.org/D105191 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

saiislam updated this revision to Diff 375672. saiislam added a comment. fixed nvptx test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105191/new/ https://reviews.llvm.org/D105191 Files: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp clang/lib/

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

saiislam updated this revision to Diff 375648. saiislam added a comment. fixed the typos in the test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105191/new/ https://reviews.llvm.org/D105191 Files: clang/lib/Driver/ToolChains/AMDGPUOpenMP

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

saiislam updated this revision to Diff 374897. saiislam marked an inline comment as done. saiislam added a comment. Added nvptx test cases, simplified amdgpu test case, modified commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105191/ne