This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG52f34673ead3: [AIX] Add _AIX73 version macro (authored by
Jake-Egan, committed by stevewan).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LA
Jake-Egan updated this revision to Diff 355613.
Jake-Egan added a comment.
Fixed formatting to be consistent with the other macro definitions.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105185/new/
https://reviews.llvm.org/D105185
Files:
clan
xgupta added inline comments.
Comment at: clang/lib/Basic/Targets/OSTargets.h:704
+if (OsVersion >= std::make_pair(7, 3))
+ Builder.defineMacro("_AIX73");
Jake-Egan wrote:
> xgupta wrote:
> > Jake-Egan wrote:
> > > xgupta wrote:
> > > > Seems this line
Jake-Egan added inline comments.
Comment at: clang/lib/Basic/Targets/OSTargets.h:704
+if (OsVersion >= std::make_pair(7, 3))
+ Builder.defineMacro("_AIX73");
xgupta wrote:
> Jake-Egan wrote:
> > xgupta wrote:
> > > Seems this line need formatting?
> >
xgupta added inline comments.
Comment at: clang/lib/Basic/Targets/OSTargets.h:704
+if (OsVersion >= std::make_pair(7, 3))
+ Builder.defineMacro("_AIX73");
Jake-Egan wrote:
> xgupta wrote:
> > Seems this line need formatting?
> I originally had it match
Jake-Egan added inline comments.
Comment at: clang/lib/Basic/Targets/OSTargets.h:704
+if (OsVersion >= std::make_pair(7, 3))
+ Builder.defineMacro("_AIX73");
xgupta wrote:
> Seems this line need formatting?
I originally had it matching the format of th
xgupta accepted this revision.
xgupta added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clang/lib/Basic/Targets/OSTargets.h:704
+if (OsVersion >= std::make_pair(7, 3))
+ Builder.defineMacro("_AIX73");
Seems this line
