[PATCH] D105177: [clangd] Implemented indexing of standard library

sammccall added a comment. In D105177#3156597 , @nridge wrote: > What is the status of this -- is it ready to be merged? This works as far as it goes, but it needs someone to wire it up completely: build these indexes somewhere that's less blocking than

[PATCH] D105177: [clangd] Implemented indexing of standard library

nridge added a comment. What is the status of this -- is it ready to be merged? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105177/new/ https://reviews.llvm.org/D105177 ___ cfe-commits mailing list cfe

[PATCH] D105177: [clangd] Implemented indexing of standard library

kuhnel updated this revision to Diff 367787. kuhnel added a comment. fixing windows build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105177/new/ https://reviews.llvm.org/D105177 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-ext

[PATCH] D105177: [clangd] Implemented indexing of standard library

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Remainder is just nits, looks good! Comment at: clang-tools-extra/clangd/FS.cpp:126 + // safely assume to exist is "/". + return "/"; +#endif "/virtu

[PATCH] D105177: [clangd] Implemented indexing of standard library

kuhnel updated this revision to Diff 367737. kuhnel marked an inline comment as done. kuhnel added a comment. addressed code review comments also fixed use-after-free Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105177/new/ https://reviews.llvm.o

[PATCH] D105177: [clangd] Implemented indexing of standard library

kuhnel marked an inline comment as done. kuhnel added inline comments. Comment at: clang-tools-extra/clangd/unittests/StdLibIndexTests.cpp:51 + Req.AnyScope = true; + EXPECT_THAT(match(*Index, Req), + UnorderedElementsAre(llvm::StringRef("myfunc"),

[PATCH] D105177: [clangd] Implemented indexing of standard library

nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/StdLibIndexTests.cpp:51 + Req.AnyScope = true; + EXPECT_THAT(match(*Index, Req), + UnorderedElementsAre(llvm::StringRef("myfunc"), kuhnel wrote: > @sammccall I seem to be

[PATCH] D105177: [clangd] Implemented indexing of standard library

kuhnel added inline comments. Comment at: clang-tools-extra/clangd/index/StdLib.cpp:72 + Inputs.TFS = &TFS; + // TODO: can we get a real compile command from somewhere? + Inputs.CompileCommand.Directory = virtualRoot().str(); nridge wrote: > sammccall wrote: >

[PATCH] D105177: [clangd] Implemented indexing of standard library

kuhnel updated this revision to Diff 367523. kuhnel marked 18 inline comments as done. kuhnel added a comment. addressed review comments, has use-after-free problem Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105177/new/ https://reviews.llvm.org/

[PATCH] D105177: [clangd] Implemented indexing of standard library

sammccall added a comment. > I removed Refs, Relations and Graph as per your comment. However I have to > admit, I don't know what they are and how they are used. > What's a good place to look at so that I learn what they do? Sorry about missing this. The best place is the `SymbolIndex` interfac

[PATCH] D105177: [clangd] Implemented indexing of standard library

nridge added inline comments. Comment at: clang-tools-extra/clangd/index/StdLib.cpp:72 + Inputs.TFS = &TFS; + // TODO: can we get a real compile command from somewhere? + Inputs.CompileCommand.Directory = virtualRoot().str(); sammccall wrote: > I'm not sure wh

[PATCH] D105177: [clangd] Implemented indexing of standard library

sammccall added inline comments. Comment at: clang-tools-extra/clangd/FS.h:77 +/// Get a virtual root node for the filesystem depending on the OS +inline const llvm::StringLiteral virtualRoot() { "node" doesn't mean anything here. Comment at:

[PATCH] D105177: [clangd] Implemented indexing of standard library

kuhnel updated this revision to Diff 365415. kuhnel added a comment. fixed a couple of bugs - wrong usage of llvm::unique - wrong usage of static pointer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105177/new/ https://reviews.llvm.org/D105177 F

[PATCH] D105177: [clangd] Implemented indexing of standard library

kuhnel updated this revision to Diff 365370. kuhnel added a comment. tried to fix Windows build failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105177/new/ https://reviews.llvm.org/D105177 Files: clang-tools-extra/clangd/CMakeLists.txt c

[PATCH] D105177: [clangd] Implemented indexing of standard library

kuhnel added a comment. > Main points in the implementation are: > > - simplify the exposed interface Good point, I added a new function `indexStandardLibrary()` as external interface. > - i don't think we need to mess with VFS at all actually Yes, removed that. > - we should think a little a

[PATCH] D105177: [clangd] Implemented indexing of standard library

kuhnel updated this revision to Diff 365181. kuhnel marked 29 inline comments as done. kuhnel edited the summary of this revision. kuhnel added a comment. Herald added a subscriber: mgrang. addressed code review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D105177: [clangd] Implemented indexing of standard library

sammccall added a comment. Sorry about the delay here, and welcome back! The core design looks sensible to me - we talked about making this part of the background index (which could reuse more code) but we don't actually want the data mixed together. Main points in the implementation are: - s

[PATCH] D105177: [clangd] Implemented indexing of standard library

kuhnel updated this revision to Diff 355478. kuhnel added a comment. using EXPECT_THAT_EXPECTED Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105177/new/ https://reviews.llvm.org/D105177 Files: clang-tools-extra/clangd/CMakeLists.txt clang-too

[PATCH] D105177: [clangd] Implemented indexing of standard library

kuhnel updated this revision to Diff 355466. kuhnel added a comment. forgot header comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105177/new/ https://reviews.llvm.org/D105177 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-ex

[PATCH] D105177: [clangd] Implemented indexing of standard library

kuhnel created this revision. Herald added subscribers: usaxena95, kadircet, arphaman, mgorny. kuhnel requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This is only the indexing part, it is NOT wired up to t