[PATCH] D105167: [analyzer] Fix HTML report deduplication.

2021-08-26 Thread Artem Dergachev via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG73093599287c: [analyzer] Fix scan-build report deduplication. (authored by dergachev.a). Herald added a project: clang. Repository: rG LLVM Github

[PATCH] D105167: [analyzer] Fix HTML report deduplication.

2021-08-26 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. In D105167#2949521 , @ASDenysPetrov wrote: > Nice work! Unfortunately I'm not able to run tests on my Windows env, but > I've run you tests files manually. It works for me. > > P.S. BTW, is there any workarounds to make current test

[PATCH] D105167: [analyzer] Fix HTML report deduplication.

2021-08-26 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ updated this revision to Diff 368917. NoQ marked 4 inline comments as done. NoQ added a comment. Address review comments! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105167/new/ https://reviews.llvm.org/D105167 Files: clang/include/clang/Analysis/PathDiagnostic.h clang/includ

[PATCH] D105167: [analyzer] Fix HTML report deduplication.

2021-08-17 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov accepted this revision. ASDenysPetrov added a comment. Nice work! Unfortunately I'm not able to run tests on my Windows env, but I've run you tests files manually. It works for me. P.S. BTW, is there any workarounds to make current tests supported on Windows? I know there is //REQ

[PATCH] D105167: [analyzer] Fix HTML report deduplication.

2021-06-30 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko accepted this revision. vsavchenko added a comment. This revision is now accepted and ready to land. This is incredible! Thanks for addressing it! I've encountered this many times. Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:277 + + std::strings

[PATCH] D105167: [analyzer] Fix HTML report deduplication.

2021-06-30 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. AFAIK from CodeChecker's side we are fine with this change. I think we are not using the `stable-report-filename` analyzer config either. Aside from these, the less //Perl// the better, I guess. Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostic

[PATCH] D105167: [analyzer] Fix HTML report deduplication.

2021-06-29 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ created this revision. NoQ added reviewers: vsavchenko, xazax.hun, Szelethus, ASDenysPetrov. Herald added subscribers: manas, steakhal, martong, dkrupp, donat.nagy, arphaman, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. NoQ requested review of this revision. Folks, I dele