[PATCH] D104971: [Matrix] Minor fixes with language extension docs

2021-06-26 Thread Saurabh Jha via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc8f3f46c6983: [Docs] Minor fixes with language extension docs (authored by SaurabhJha). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D104971: [Matrix] Minor fixes with language extension docs

2021-06-26 Thread Saurabh Jha via Phabricator via cfe-commits
SaurabhJha added a comment. In D104971#2842319 , @xgupta wrote: > btw you should use [Docs] or [NFC] tag for this patch. Okay, will follow the linked docs and amend the commit message with [Docs]. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D104971: [Matrix] Minor fixes with language extension docs

2021-06-26 Thread Shivam Gupta via Phabricator via cfe-commits
xgupta added a comment. btw you should use [Docs] or [NFC] for this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104971/new/ https://reviews.llvm.org/D104971 ___ cfe-commits mailing list cfe-com

[PATCH] D104971: [Matrix] Minor fixes with language extension docs

2021-06-26 Thread Shivam Gupta via Phabricator via cfe-commits
xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. In D104971#2842293 , @SaurabhJha wrote: > This is a light patch that probably does not require a review and I created a > patch anyway. > > Would it

[PATCH] D104971: [Matrix] Minor fixes with language extension docs

2021-06-26 Thread Saurabh Jha via Phabricator via cfe-commits
SaurabhJha added a comment. This is a light patch that probably does not require a review and I created a patch anyway. Would it be appropriate to get this into main using `arc land` if this is approved? I saw this https://reviews.llvm.org/D78867 which advises against `arc land` but could not

[PATCH] D104971: [Matrix] Minor fixes with language extension docs

2021-06-26 Thread Saurabh Jha via Phabricator via cfe-commits
SaurabhJha created this revision. Herald added a subscriber: tschuett. SaurabhJha requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There were some issues in the patch https://reviews.llvm.org/D104198. I also forgot to address one comment. T