[PATCH] D104844: [Analyzer][solver] Fix crashes during symbol simplification

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1981 for (const SymbolRef &MemberSym : ClassMembers) { -SymbolRef SimplifiedMemberSym = ::simplify(State, MemberSym); +SymbolRef SimplifiedMemberSym = ::clang::ento::

[PATCH] D104844: [Analyzer][solver] Fix crashes during symbol simplification

This revision was automatically updated to reflect the committed changes. martong marked an inline comment as done. Closed by commit rG0646e3625499: [Analyzer][solver] Fix crashes during symbol simplification (authored by martong). Changed prior to commit: https://reviews.llvm.org/D104844?vs=35

[PATCH] D104844: [Analyzer][solver] Fix crashes during symbol simplification

martong marked 2 inline comments as done. martong added a comment. Valeriy, thanks for the assiduous and quick review! Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1981 for (const SymbolRef &MemberSym : ClassMembers) { -SymbolRef SimplifiedMemberS

[PATCH] D104844: [Analyzer][solver] Fix crashes during symbol simplification

vsavchenko added a comment. Awesome, thanks for swiftly addressing it! Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1981 for (const SymbolRef &MemberSym : ClassMembers) { -SymbolRef SimplifiedMemberSym = ::simplify(State, MemberSym); +SymbolRe

[PATCH] D104844: [Analyzer][solver] Fix crashes during symbol simplification

martong marked 2 inline comments as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:2314-2315 + if (SymbolRef SimplifiedSym = simplify(St, Sym)) +Sym = SimplifiedSym; + vsavchenko wrote: > martong w

[PATCH] D104844: [Analyzer][solver] Fix crashes during symbol simplification

martong updated this revision to Diff 354274. martong added a comment. - Use simplify from RangedConstraintManager Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104844/new/ https://reviews.llvm.org/D104844 Files: clang/include/clang/StaticAnaly

[PATCH] D104844: [Analyzer][solver] Fix crashes during symbol simplification

vsavchenko added a comment. In D104844#2838674 , @martong wrote: >> I don't really get why we get not simplified symbol to begin with. > > This is because of the Environment bindings. I.e.` b1` is bound to `$a0 - $b0 > + $c` when we evaluate `int b1 = (u

[PATCH] D104844: [Analyzer][solver] Fix crashes during symbol simplification

martong added a comment. > I don't really get why we get not simplified symbol to begin with. This is because of the Environment bindings. I.e.` b1` is bound to `$a0 - $b0 + $c` when we evaluate `int b1 = (unsigned)a1 + c;`. This binding is not changed/updated, so when we evaluate the division

[PATCH] D104844: [Analyzer][solver] Fix crashes during symbol simplification

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:2314-2315 + if (SymbolRef SimplifiedSym = simplify(St, Sym)) +Sym = SimplifiedSym; + vsavchenko wrote: > I don't like the idea of duplicating it into every

[PATCH] D104844: [Analyzer][solver] Fix crashes during symbol simplification

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:2314-2315 + if (SymbolRef SimplifiedSym = simplify(St, Sym)) +Sym = SimplifiedSym; + I don't like the idea of duplicating it into every `assume` method.

[PATCH] D104844: [Analyzer][solver] Fix crashes during symbol simplification

martong created this revision. martong added reviewers: vsavchenko, steakhal. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer: Szelethus. mart