This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf3ef4f5bff26: [PowerPC] Add XL compat __compare_and_swap
builtins (authored by jsji).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTI
jsji added inline comments.
Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-cas.c:19
+// CHECK-NEXT:[[TMP2:%.*]] = cmpxchg weak volatile i32* [[A]], i32
[[TMP1]], i32 [[TMP0]] monotonic monotonic, align 4
+// CHECK-NEXT:[[TMP3:%.*]] = extractvalue { i32, i1 } [[TMP2
jsji updated this revision to Diff 354410.
jsji added a comment.
Address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104837/new/
https://reviews.llvm.org/D104837
Files:
clang/include/clang/Basic/BuiltinsPPC.def
clang/lib/Basic/Targ
w2yehia accepted this revision.
w2yehia added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-cas.c:19
+// CHECK-NEXT:[[TMP2:%.*]] = cmpxchg weak volatile i32* [[A]], i32
[[TMP1]], i32 [[TMP0]] monotonic
jsji updated this revision to Diff 354360.
jsji added a comment.
Add {} to case.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104837/new/
https://reviews.llvm.org/D104837
Files:
clang/include/clang/Basic/BuiltinsPPC.def
clang/lib/Basic/Target
jsji created this revision.
jsji added reviewers: PowerPC, lkail, w2yehia.
Herald added subscribers: shchenz, jfb, kbarton, nemanjai.
jsji requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Prototype
int __compare_and_swap (volatile int* addr,