[PATCH] D104766: [X86] Zero some outputs of Keylocker intrinsics in error case

2021-07-02 Thread Xiang Zhang via Phabricator via cfe-commits
xiangzhangllvm added a comment. Done at https://reviews.llvm.org/D105336, thanks again! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104766/new/ https://reviews.llvm.org/D104766 ___ cfe-commits mailing

[PATCH] D104766: [X86] Zero some outputs of Keylocker intrinsics in error case

2021-07-02 Thread Xiang Zhang via Phabricator via cfe-commits
xiangzhangllvm added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:14834 +BasicBlock *NoError = createBasicBlock(StrNoErr, this->CurFn); +BasicBlock *Error = createBasicBlock(StrErr, this->CurFn); craig.topper wrote: > Sorry I'm late here

[PATCH] D104766: [X86] Zero some outputs of Keylocker intrinsics in error case

2021-06-29 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:14834 +BasicBlock *NoError = createBasicBlock(StrNoErr, this->CurFn); +BasicBlock *Error = createBasicBlock(StrErr, this->CurFn); Sorry I'm late here. Instead of having 3 se