This revision was automatically updated to reflect the committed changes.
Closed by commit rG544d20eab662: [clangd] Dont index ObjCCategoryDecls for
completion (authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104540/new/
https:/
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1918
+ // from the index, we reduce the noise in all the other completion scopes.
+ if (llvm::isa(&ND))
+return false;
dgoldman wrote:
> Seems like we should also ignore O
kadircet updated this revision to Diff 353658.
kadircet marked an inline comment as done.
kadircet added a comment.
- Also handle ObjcCategoryImplDecl
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104540/new/
https://reviews.llvm.org/D104540
Files
dgoldman added inline comments.
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1918
+ // from the index, we reduce the noise in all the other completion scopes.
+ if (llvm::isa(&ND))
+return false;
Seems like we should also ignore ObjCCategoryImplDec
kadircet created this revision.
kadircet added a reviewer: dgoldman.
Herald added subscribers: usaxena95, arphaman.
kadircet requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
They are already provided by Sem
