[PATCH] D104459: [clang][lex] Ensure minimizer output is never larger than input

2021-06-17 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. Another thing to consider: a client that wants the minimized source to be "no bigger than" the original source can use the original source if it ends up growing. For example, https://reviews.llvm.org/D104462 could check the resulting size, and just return the origina

[PATCH] D104459: [clang][lex] Ensure minimizer output is never larger than input

2021-06-17 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. > This patch ensures the output of source minimizer is never larger than the > input. This property will be handy in a follow up patch that makes it > possible to pad the minimized output to the size of the original input. I suppose when I wrote first wrote this I wa

[PATCH] D104459: [clang][lex] Ensure minimizer output is never larger than input

2021-06-17 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 updated this revision to Diff 352726. jansvoboda11 added a comment. Fix assert wording Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104459/new/ https://reviews.llvm.org/D104459 Files: clang/lib/Lex/DependencyDirectivesSourceMinimiz

[PATCH] D104459: [clang][lex] Ensure minimizer output is never larger than input

2021-06-17 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch ensures the output of source minimizer is never larger than the inpu