[PATCH] D104344: [modules] Track how headers are included by different submodules.

vsapsai planned changes to this revision. vsapsai added a comment. Investigate less heavy-weight approaches similar to those used for tracking macros from different submodules. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104344/new/ https://revi

[PATCH] D104344: [modules] Track how headers are included by different submodules.

vsapsai added a comment. That's a good point. Let me check how we track macros, I haven't thought about that approach. And I haven't considered using `Preprocessor::SubmoduleState`, was too excited `HeaderSearch::ShouldEnterIncludeFile` works correctly with the updated data.

[PATCH] D104344: [modules] Track how headers are included by different submodules.

rsmith added a comment. I wonder if perhaps we're tracking this state in the wrong way. The "has been included" information for `#pragma once` / `#import` should behave exactly like macro definition visibility: it should be reset whenever we enter a new "clean slate" state and should be saved a