[PATCH] D104342: [IR] convert warn-stack-size from module attr to fn attr

dblaikie added a comment. In D104342#2828193 , @nickdesaulniers wrote: > In D104342#2827847 , @dblaikie > wrote: > >> Another thing you might want to check is linkonce_odr functions - I guess >> you'll get an a

[PATCH] D104342: [IR] convert warn-stack-size from module attr to fn attr

nickdesaulniers updated this revision to Diff 353110. nickdesaulniers added a comment. - git add the Linker test! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104342/new/ https://reviews.llvm.org/D104342 Files: clang/lib/CodeGen/CodeGenFunction

[PATCH] D104342: [IR] convert warn-stack-size from module attr to fn attr

nickdesaulniers added a comment. In D104342#2827847 , @dblaikie wrote: > Another thing you might want to check is linkonce_odr functions - I guess > you'll get an arbitrary choice between two linkonce_odr functions under LTO > where they have different

[PATCH] D104342: [IR] convert warn-stack-size from module attr to fn attr

nickdesaulniers updated this revision to Diff 353102. nickdesaulniers added a comment. - fix lint, add linker test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104342/new/ https://reviews.llvm.org/D104342 Files: clang/lib/CodeGen/CodeGenFunctio

[PATCH] D104342: [IR] convert warn-stack-size from module attr to fn attr

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds OK to me. Another thing you might want to check is linkonce_odr functions - I guess you'll get an arbitrary choice between two linkonce_odr functions under LTO where they have diff

[PATCH] D104342: [IR] convert warn-stack-size from module attr to fn attr

nickdesaulniers updated this revision to Diff 352841. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - verifier checks, inliner test, use base 10 radix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104342/new/ ht

[PATCH] D104342: [IR] convert warn-stack-size from module attr to fn attr

dblaikie added a comment. In D104342#2825357 , @nickdesaulniers wrote: > In D104342#2820811 , @dblaikie > wrote: > >> what're the rules about module level attributes like this? For instance: >> Does this affect

[PATCH] D104342: [IR] convert warn-stack-size from module attr to fn attr

nickdesaulniers added inline comments. Comment at: llvm/lib/CodeGen/PrologEpilogInserter.cpp:282 +.getValueAsString() +.getAsInteger(0, Threshold); if (StackSize > Threshold) { nickdesaulniers wrote: > dblaikie wrote: > > I guess the 0 value he

[PATCH] D104342: [IR] convert warn-stack-size from module attr to fn attr

nickdesaulniers added a comment. In D104342#2820811 , @dblaikie wrote: > what're the rules about module level attributes like this? For instance: Does > this affect/hinder inlining (if the attributes don't match between the caller > and callee)? Other s

[PATCH] D104342: [IR] convert warn-stack-size from module attr to fn attr

dblaikie added a comment. what're the rules about module level attributes like this? For instance: Does this affect/hinder inlining (if the attributes don't match between the caller and callee)? Other situations that might matter? Comment at: llvm/lib/CodeGen/PrologEpilogInse

[PATCH] D104342: [IR] convert warn-stack-size from module attr to fn attr

nickdesaulniers created this revision. nickdesaulniers added reviewers: qcolombet, dblaikie. Herald added subscribers: dexonsmith, jdoerfert, pengfei, hiraditya. nickdesaulniers requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commit