[PATCH] D104136: [analyzer] Add better tracking for RetainCountChecker leak warnings

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.cpp:953-957 + // Let's traverse... + for (const ExplodedNode *N = ExprNode; + // ...all the nodes corresponding to the given expression...

[PATCH] D104136: [analyzer] Add better tracking for RetainCountChecker leak warnings

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.cpp:953-957 + // Let's traverse... + for (const ExplodedNode *N = ExprNode; + // ...all the nodes corresponding to the given expression..

[PATCH] D104136: [analyzer] Add better tracking for RetainCountChecker leak warnings

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountChecker.cpp:945-947 +ExprEngine &Eng = C.getStateManager().getOwningEngine(); +// Let's mark this place with a special tag. +Tag = Eng.getDataTags().make(CE,

[PATCH] D104136: [analyzer] Add better tracking for RetainCountChecker leak warnings

vsavchenko updated this revision to Diff 352652. vsavchenko added a comment. Move IdentityHandler into the anonymous namespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104136/new/ https://reviews.llvm.org/D104136 Files: clang/lib/StaticAnal

[PATCH] D104136: [analyzer] Add better tracking for RetainCountChecker leak warnings

vsavchenko added a comment. In D104136#2823834 , @Szelethus wrote: > Aha, alright! So the tracker tracked back to where the tracked expression got > computed in node `N`, which is the return value of some identity function. > Unless its explicitly told

[PATCH] D104136: [analyzer] Add better tracking for RetainCountChecker leak warnings

Szelethus added a comment. Aha, alright! So the tracker tracked back to where the tracked expression got computed to node `N`, which is the return value of some identity function. Unless its explicitly told that there is a link in between the return value and the parameter, the tracker can't fi

[PATCH] D104136: [analyzer] Add better tracking for RetainCountChecker leak warnings

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.cpp:953-957 + // Let's traverse... + for (const ExplodedNode *N = ExprNode; + // ...all the nodes corresponding to the given expression..

[PATCH] D104136: [analyzer] Add better tracking for RetainCountChecker leak warnings

vsavchenko updated this revision to Diff 352075. vsavchenko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104136/new/ https://reviews.llvm.org/D104136 Files: clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCoun

[PATCH] D104136: [analyzer] Add better tracking for RetainCountChecker leak warnings

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.cpp:953-957 + // Let's traverse... + for (const ExplodedNode *N = ExprNode; + // ...all the nodes corresponding to the given expression... +

[PATCH] D104136: [analyzer] Add better tracking for RetainCountChecker leak warnings

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, martong, steakhal, Szelethus, manas, RedDocMD. Herald added subscribers: ASDenysPetrov, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this revision.