[PATCH] D104117: [clangd] Fix highlighting for implicit ObjC property refs

This revision was automatically updated to reflect the committed changes. Closed by commit rG570984204f24: [clangd] Fix highlighting for implicit ObjC property refs (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104117/new/ ht

[PATCH] D104117: [clangd] Fix highlighting for implicit ObjC property refs

dgoldman updated this revision to Diff 355035. dgoldman added a comment. Fix clang-tidy warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104117/new/ https://reviews.llvm.org/D104117 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp

[PATCH] D104117: [clangd] Fix highlighting for implicit ObjC property refs

dgoldman updated this revision to Diff 353987. dgoldman added a comment. Minor comment fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104117/new/ https://reviews.llvm.org/D104117 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp cl

[PATCH] D104117: [clangd] Fix highlighting for implicit ObjC property refs

dgoldman added a comment. In D104117#2835599 , @sammccall wrote: > Drive by from vacation, sorry - can this be tackled "upstream" in > findExplicitReferences rather than special cased in syntax highlighting? > > That would help with xrefs, rename etc. Fe

[PATCH] D104117: [clangd] Fix highlighting for implicit ObjC property refs

sammccall added a comment. Drive by from vacation, sorry - can this be tackled "upstream" in findExplicitReferences rather than special cased in syntax highlighting? That would help with xrefs, rename etc. Features should really be only handled here if they're somehow not a simple token->decl r

[PATCH] D104117: [clangd] Fix highlighting for implicit ObjC property refs

kadircet added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:579 + return true; +// A single property expr can reference both a getter and setter, but we can +// only provide a single semantic token, so prefer the getter. ---

[PATCH] D104117: [clangd] Fix highlighting for implicit ObjC property refs

dgoldman created this revision. dgoldman added reviewers: sammccall, kadircet. Herald added subscribers: usaxena95, arphaman. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Objective-C lets you u