[PATCH] D103953: Sanitizers.h - remove MathExtras.h include dependency

2021-06-09 Thread Simon Pilgrim via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG206a66de5902: Sanitizers.h - remove MathExtras.h include dependency (authored by RKSimon). Changed prior to commit: https://reviews.llvm.org/D103953?vs=350845&id=350882#toc Repository: rG LLVM Github

[PATCH] D103953: Sanitizers.h - remove MathExtras.h include dependency

2021-06-09 Thread pierre gousseau via Phabricator via cfe-commits
pgousseau accepted this revision. pgousseau added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103953/new/ https://reviews.llvm.org/D103953

[PATCH] D103953: Sanitizers.h - remove MathExtras.h include dependency

2021-06-09 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3129 static CheckRecoverableKind getRecoverableKind(SanitizerMask Kind) { - assert(Kind.countPopulation() == 1); + assert(Kind.isPowerOf2()); if (Kind == SanitizerKind::Function || Kind == SanitizerKind

[PATCH] D103953: Sanitizers.h - remove MathExtras.h include dependency

2021-06-09 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon created this revision. RKSimon added reviewers: pgousseau, filcab, bkramer. Herald added a subscriber: dexonsmith. RKSimon requested review of this revision. Herald added a project: clang. We include the MathExtras.h header purely for the countPopulation() method - by moving this into San