[PATCH] D103943: [X86] Add -mgeneral-regs-only support.

2021-06-29 Thread Wang Tianqing via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd8faf03807ac: [X86] Add -mgeneral-regs-only support. (authored by tianqing). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D103943: [X86] Add -mgeneral-regs-only support.

2021-06-23 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon added a comment. Thanks - that makes sense - LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103943/new/ https://reviews.llvm.org/D103943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[PATCH] D103943: [X86] Add -mgeneral-regs-only support.

2021-06-23 Thread Pengfei Wang via Phabricator via cfe-commits
pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103943/new/ https://reviews.llvm.org/D103943 ___ cfe-commits mailing list cfe-commit

[PATCH] D103943: [X86] Add -mgeneral-regs-only support.

2021-06-21 Thread Wang Tianqing via Phabricator via cfe-commits
tianqing marked an inline comment as done. tianqing added inline comments. Comment at: clang/include/clang/Driver/Options.td:3214 -def mgeneral_regs_only : Flag<["-"], "mgeneral-regs-only">, Group, - HelpText<"Generate code which only uses the general purpose registers (AArc

[PATCH] D103943: [X86] Add -mgeneral-regs-only support.

2021-06-21 Thread Wang Tianqing via Phabricator via cfe-commits
tianqing updated this revision to Diff 353536. tianqing added a comment. Fix lint comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103943/new/ https://reviews.llvm.org/D103943 Files: clang/include/clang/Driver/Options.td clang/lib/Basic/Targets/X86.cpp clang/lib/Driver/Tool

[PATCH] D103943: [X86] Add -mgeneral-regs-only support.

2021-06-21 Thread Pengfei Wang via Phabricator via cfe-commits
pengfei added inline comments. Comment at: clang/include/clang/Driver/Options.td:3214 -def mgeneral_regs_only : Flag<["-"], "mgeneral-regs-only">, Group, - HelpText<"Generate code which only uses the general purpose registers (AArch64 only)">; +def mgeneral_regs_only : Flag<

[PATCH] D103943: [X86] Add -mgeneral-regs-only support.

2021-06-16 Thread Wang Tianqing via Phabricator via cfe-commits
tianqing added a comment. In D103943#2812638 , @RKSimon wrote: > I don't know much about target feature inheritance - does this guarantee that > the entire sse/avx/avx512 level chain is correctly disabled? setFeatureEnabled queries ImpliedFeatures to di

[PATCH] D103943: [X86] Add -mgeneral-regs-only support.

2021-06-16 Thread Wang Tianqing via Phabricator via cfe-commits
tianqing updated this revision to Diff 352616. tianqing added a comment. Respect order of options. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103943/new/ https://reviews.llvm.org/D103943 Files: clang/include/clang/Driver/Options.td clang/lib/Basic/Targets/X86.cpp clang/lib/Dri

[PATCH] D103943: [X86] Add -mgeneral-regs-only support.

2021-06-11 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon added a comment. I don't know much about target feature inheritance - does this guarantee that the entire sse/avx/avx512 level chain is correctly disabled? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103943/new/ https://reviews.llvm.org/

[PATCH] D103943: [X86] Add -mgeneral-regs-only support.

2021-06-08 Thread Wang Tianqing via Phabricator via cfe-commits
tianqing created this revision. Herald added a subscriber: dang. tianqing requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D103943 Files: clang/include/clang/Driver/Options.t