[PATCH] D103888: [ADT] Remove APInt/APSInt toString() std::string variants

dblaikie added a comment. In D103888#2813236 , @RKSimon wrote: > In D103888#2811305 , @dblaikie > wrote: > >> Sounds OK. >> >> I wouldn't mind the places that can use op<< to use that - not sure >> preserving th

[PATCH] D103888: [ADT] Remove APInt/APSInt toString() std::string variants

RKSimon added a comment. In D103888#2811305 , @dblaikie wrote: > Sounds OK. > > I wouldn't mind the places that can use op<< to use that - not sure > preserving the explicit radix argument is super high value. (I think people > would generally assume th

[PATCH] D103888: [ADT] Remove APInt/APSInt toString() std::string variants

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG61cdaf66fe22: [ADT] Remove APInt/APSInt toString() std::string variants (authored by RKSimon). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D103888: [ADT] Remove APInt/APSInt toString() std::string variants

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds OK. I wouldn't mind the places that can use op<< to use that - not sure preserving the explicit radix argument is super high value. (I think people would generally assume that's th

[PATCH] D103888: [ADT] Remove APInt/APSInt toString() std::string variants

RKSimon updated this revision to Diff 350893. RKSimon added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103888/new/ https://reviews.llvm.org/D103888 Files: clang-tools-extra/clang-tidy/abseil/DurationRewriter.cpp clang-too

[PATCH] D103888: [ADT] Remove APInt/APSInt toString() std::string variants

RKSimon created this revision. RKSimon added reviewers: nikic, bkramer, craig.topper, dblaikie, rsmith, zturner. Herald added subscribers: ormris, dexonsmith, martong, usaxena95, pengfei, kadircet, arphaman, kbarton, hiraditya, nemanjai. Herald added a reviewer: aaron.ballman. RKSimon requested r