[PATCH] D103825: [clang] Do not crash when ArgTy is null in CheckArgAlignment

This revision was automatically updated to reflect the committed changes. Closed by commit rG49eba8bf1780: [clang] Do not crash when ArgTy is null in CheckArgAlignment (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103825/new/ h

[PATCH] D103825: [clang] Do not crash when ArgTy is null in CheckArgAlignment

hokein accepted this revision. hokein added a comment. Thanks! Really hope this is the last time to fix this crash. Comment at: clang/lib/Sema/SemaChecking.cpp:4574 // getTypeAlignInChars requires complete types - if (ParamTy->isIncompleteType() || ArgTy->isIncompleteType()

[PATCH] D103825: [clang] Do not crash when ArgTy is null in CheckArgAlignment

adamcz updated this revision to Diff 351155. adamcz added a comment. updated after the CXXDefaultArgExpr containsErrors() change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103825/new/ https://reviews.llvm.org/D103825 Files: clang/lib/Sema/Se

[PATCH] D103825: [clang] Do not crash when ArgTy is null in CheckArgAlignment

adamcz added a comment. Thanks Haojian! I sent out https://reviews.llvm.org/D103982 for the CXXDefaultArgExpr. I'll update this change after I submit that one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103825/new/ https://reviews.llvm.org/D103

[PATCH] D103825: [clang] Do not crash when ArgTy is null in CheckArgAlignment

hokein added a comment. In D103825#2805760 , @adamcz wrote: > FYI The ArgTy.isNull() check is sufficient to fix this. The > Arg->containsErrors() is not - it's false in this case, since it seems > CXXDefaultArgExpr with RecoveryExpr inside seems to not

[PATCH] D103825: [clang] Do not crash when ArgTy is null in CheckArgAlignment

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. as discussed offline LG from my side. regarding the default arg of a parameter containing an error, it seems to be effecting type information of the parameter even though the type is expli

[PATCH] D103825: [clang] Do not crash when ArgTy is null in CheckArgAlignment

adamcz added reviewers: kadircet, hokein. adamcz added a comment. FYI The ArgTy.isNull() check is sufficient to fix this. The Arg->containsErrors() is not - it's false in this case, since it seems CXXDefaultArgExpr with RecoveryExpr inside seems to not contains errors, according to containsErro

[PATCH] D103825: [clang] Do not crash when ArgTy is null in CheckArgAlignment

adamcz updated this revision to Diff 350629. adamcz added a comment. Added some containsErrors() calls, not sure if that's the right thing to do Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103825/new/ https://reviews.llvm.org/D103825 Files: cl

[PATCH] D103825: [clang] Do not crash when ArgTy is null in CheckArgAlignment

adamcz updated this revision to Diff 350613. adamcz added a comment. update commit description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103825/new/ https://reviews.llvm.org/D103825 Files: clang/lib/Sema/SemaChecking.cpp clang/test/SemaCXX

[PATCH] D103825: [clang] Do not crash when ArgTy is null in CheckArgAlignment

adamcz updated this revision to Diff 350612. adamcz added a comment. added a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103825/new/ https://reviews.llvm.org/D103825 Files: clang/lib/Sema/SemaChecking.cpp clang/test/SemaCXX/recovery-exp

[PATCH] D103825: [clang] Do not crash when ArgTy is null in CheckArgAlignment

kadircet added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4567 if (ParamTy->isPointerType()) ArgTy = ArgTy->getPointeeType(); i think ArgTy becomes null after this operation. e.g. the function requires a pointer param, user provides a

[PATCH] D103825: [clang] Do not crash when ArgTy is null in CheckArgAlignment

adamcz created this revision. adamcz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. No repro case just yet. I only observed a crash like this and noticed ArgTy-Value = 0 in coredump. Repository: rG LLVM Github Monorepo https://reviews