zero9178 marked an inline comment as done.
zero9178 added inline comments.
Comment at: clang/test/Driver/cl-permissive.c:15
+// PERMISSIVE-OVERWRITE-NOT: "-fdelayed-template-parsing"
+// RUN: %clang_cl /permissive- /Zc:twoPhase- -### -- %s 2>&1 | FileCheck
-check-prefix=PERMISSI
zero9178 added inline comments.
Comment at: clang/test/Driver/cl-permissive.c:15
+// PERMISSIVE-OVERWRITE-NOT: "-fdelayed-template-parsing"
+// RUN: %clang_cl /permissive- /Zc:twoPhase- -### -- %s 2>&1 | FileCheck
-check-prefix=PERMISSIVE-MINUS-OVERWRITE %s
+// PERMISSIVE-MINUS-
aganea added inline comments.
Comment at: clang/test/Driver/cl-permissive.c:15
+// PERMISSIVE-OVERWRITE-NOT: "-fdelayed-template-parsing"
+// RUN: %clang_cl /permissive- /Zc:twoPhase- -### -- %s 2>&1 | FileCheck
-check-prefix=PERMISSIVE-MINUS-OVERWRITE %s
+// PERMISSIVE-MINUS-OV
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc70b0e808da8: [clang-cl] Add /permissive and /permissive-
(authored by zero9178).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
zero9178 added a comment.
I shall do that.
I do have commit access, but thanks for asking.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103773/new/
https://reviews.llvm.org/D103773
___
cfe-commits mail
thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.
Since it's motivated by a concrete file, this makes sense to me. Wait maybe a
day or so to see if anyone objects, but I think this (and dependencies) are
good.
Do you have commit access?
Re
zero9178 added a comment.
> I think adding /permissive- to make things more conforming is great. The docs
> say "Starting in Visual Studio 2019 version 16.8, the /std:c++latest option
> implicitly sets the /permissive- option." so maybe we should do that too
> (doesn't have to be in this patch)
thakis added a comment.
I think adding `/permissive-` to make things more conforming is great. The docs
say "Starting in Visual Studio 2019 version 16.8, the /std:c++latest option
implicitly sets the /permissive- option." so maybe we should do that too
(doesn't have to be in this patch).
Since
zero9178 created this revision.
zero9178 added reviewers: rnk, thakis, hans, mstorsjo.
Herald added a subscriber: dang.
zero9178 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This patch adds the command line options /permissive and /permi
