[PATCH] D103720: [clang] NFC: Rename rvalue to prvalue

This revision was automatically updated to reflect the committed changes. Closed by commit rGaef5d8fdc7d0: [clang] NFC: Rename rvalue to prvalue (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103720/new/ https://reviews.llvm.o

[PATCH] D103720: [clang] NFC: Rename rvalue to prvalue

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103720/new/ https://reviews.llvm.org/D103720 __

[PATCH] D103720: [clang] NFC: Rename rvalue to prvalue

mizvekov marked an inline comment as done. mizvekov added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5662 switch (ET) { case ET_IsLValueExpr: return E->isLValue(); + case ET_IsRValueExpr: rsmith wrote: > Hm, I wonder if this it's correct t

[PATCH] D103720: [clang] NFC: Rename rvalue to prvalue

mizvekov marked an inline comment as done. mizvekov added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:3588 + case VK_PRValue: +S.Kind = SK_CastDerivedToBaseRValue; +break; rsmith wrote: > Would be nice to rename this `SK_` enumerator as a fo

[PATCH] D103720: [clang] NFC: Rename rvalue to prvalue

mizvekov updated this revision to Diff 350729. mizvekov added a comment. Implement rsmith's suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103720/new/ https://reviews.llvm.org/D103720 Files: clang-tools-extra/clang-tidy/misc/Uniquept

[PATCH] D103720: [clang] NFC: Rename rvalue to prvalue

rsmith added a comment. I think this is worth doing -- "rvalue" is at least ambiguous and, in C++-specific cases, confusing and wrong. Saying "prvalue" in C-specific parts of clang may also be a bit surprising, but it's unambiguous and still meaningful. I think we shouldn't consider adding an

[PATCH] D103720: [clang] NFC: Rename rvalue to prvalue

mizvekov added a comment. In D103720#2806147 , @aaron.ballman wrote: > (esp if someone in the future wants to add `Expr::isRValue()` with the C++ > meaning of prvalue || xvalue). @rsmith actually suggested we add `isRValue` as a second step here, and I

[PATCH] D103720: [clang] NFC: Rename rvalue to prvalue

aaron.ballman added a comment. Thank you for the terminology cleanup! I'm not opposed to the changes, but I am wondering whether the churn is worth it given that the nomenclature will still be confusing for those thinking about non-C++ based languages (esp if someone in the future wants to add

[PATCH] D103720: [clang] NFC: Rename rvalue to prvalue

mizvekov updated this revision to Diff 350006. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103720/new/ https://reviews.llvm.org/D103720 Files: clang-tools-extra/clang-tidy/misc/UniqueptrResetReleaseCheck.cpp clang