This revision was automatically updated to reflect the committed changes.
Closed by commit rG4728aca9a8ad: [clangd] Drop TestTUs dependency on gtest
(authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103685/new/
https://reviews.ll
kadircet updated this revision to Diff 350231.
kadircet added a comment.
- Assert for daigs rather than abort.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103685/new/
https://reviews.llvm.org/D103685
Files:
clang-tools-extra/clangd/index/Symbo
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/unittests/TestTU.cpp:122
if (!AST->getDiagnostics()) {
-ADD_FAILURE() << "TestTU should always build an AST with a fresh
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/unittests/TestTU.cpp:75
+ if (llvm::sys::fs::createUniqueDirectory("module-cache", ModuleCachePath))
+llvm_unreachable("Failed to create temp directory for module-cache");
CI.getHeaderSearchOpts().Module
kadircet updated this revision to Diff 350206.
kadircet marked 3 inline comments as done.
kadircet added a comment.
- Use log + abort instead of llvm_unreachable to not rely on UB.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103685/new/
https://r
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/unittests/TestTU.cpp:75
+ if (llvm::sys::fs::createUniqueDirectory("module-cache", ModuleCachePath))
+llvm_unreachable("Failed to create temp directory for module-cache");
CI.getHeaderSearchOpts().Modul
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: usaxena95, arphaman.
kadircet requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
TestTU now prints errors to llv
