[PATCH] D103664: [Windows SEH]: Fix -O2 crash for Windows -EHa

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG33ba8bd2c942: [Windows SEH]: Fix -O2 crash for Windows -EHa (authored by tentzen). Repository: rG LLVM Github Monorepo

[PATCH] D103664: [Windows SEH]: Fix -O2 crash for Windows -EHa

zahiraam added a comment. In D103664#2799944 , @tentzen wrote: > since I cannot repro it locally, let's have this patch in to resolve -EHa -O2 > crashes for now. > I will add more -O2 tests in following patches. Sounds good to me! Repository: rG LLV

[PATCH] D103664: [Windows SEH]: Fix -O2 crash for Windows -EHa

tentzen added a comment. since I cannot repro it locally, let's have this patch in to resolve -EHa -O2 crashes for now. I will add more -O2 tests in following patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103664/new/ https://reviews.llvm.

[PATCH] D103664: [Windows SEH]: Fix -O2 crash for Windows -EHa

zahiraam added a comment. In D103664#2799852 , @tentzen wrote: > @zahiraam, are you removing all those CHECKs: > > - CHECK: invoke void @llvm.seh.scope.** > > those are placed there to ensure SEH scope semantic is preserved for Od.. I was just showing yo

[PATCH] D103664: [Windows SEH]: Fix -O2 crash for Windows -EHa

tentzen added a comment. @zahiraam, are you removing all those CHECKs: - CHECK: invoke void @llvm.seh.scope.** those are placed there to ensure SEH scope semantic is preserved for Od.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103664/new/ htt

[PATCH] D103664: [Windows SEH]: Fix -O2 crash for Windows -EHa

zahiraam added a comment. In D103664#2799725 , @tentzen wrote: > In D103664#2798732 , @aganea wrote: > >> Thanks for the quick fix! Would you mind fixing the two failing tests >> please? (see above) > > Hmm, I ca

[PATCH] D103664: [Windows SEH]: Fix -O2 crash for Windows -EHa

tentzen updated this revision to Diff 349939. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103664/new/ https://reviews.llvm.org/D103664 Files: clang/lib/CodeGen/CGCleanup.cpp clang/lib/Driver/ToolChains/Clang.cpp Index: clang/lib/Driver/ToolC

[PATCH] D103664: [Windows SEH]: Fix -O2 crash for Windows -EHa

tentzen added a comment. In D103664#2798732 , @aganea wrote: > Thanks for the quick fix! Would you mind fixing the two failing tests please? > (see above) Hmm, I cannot repro locally.. @zahiraam, currently -EHa is not completely ready yet. we need a co

[PATCH] D103664: [Windows SEH]: Fix -O2 crash for Windows -EHa

zahiraam added a comment. wco Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7155 -if (EH.Asynch) - CmdArgs.push_back("-fasync-exceptions"); } Not really sure I understand this change. Isn't the case that if I compile with -EHa, I want the -fasy

[PATCH] D103664: [Windows SEH]: Fix -O2 crash for Windows -EHa

aganea added a comment. Thanks for the quick fix! Would you mind fixing the two failing tests please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103664/new/ https://reviews.llvm.org/D103664 ___ cfe-co

[PATCH] D103664: [Windows SEH]: Fix -O2 crash for Windows -EHa

tentzen created this revision. tentzen added reviewers: asmith, aganea, zahiraam. tentzen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch fixes a Windows -EHa crash induced by previous commit 797ad701522988e212495285dade8efac41a