foad added inline comments.
Comment at: llvm/lib/Target/AMDGPU/AMDGPU.td:471
+ "true",
+ "Encoding format GFX10_A"
+>;
bcahoon wrote:
> foad wrote:
> > I realise you're just following the precedent set by GFX10_B, but is this
> > terminology actually used in a
bcahoon marked an inline comment as done.
bcahoon added inline comments.
Comment at: llvm/lib/Target/AMDGPU/AMDGPU.td:471
+ "true",
+ "Encoding format GFX10_A"
+>;
foad wrote:
> I realise you're just following the precedent set by GFX10_B, but is this
> termin
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGea10a86984ea: [AMDGPU] Add gfx1013 target (authored by
bcahoon).
Changed prior to commit:
https://reviews.llvm.org/D103663?vs=350468&id=350640#toc
foad accepted this revision.
foad added a comment.
LGTM anyway, with or without any action on my last couple of comments.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103663/new/
https://reviews.llvm.org/D103663
___
cfe-commits mailing list
foad added inline comments.
Comment at: llvm/lib/Target/AMDGPU/AMDGPU.td:471
+ "true",
+ "Encoding format GFX10_A"
+>;
I realise you're just following the precedent set by GFX10_B, but is this
terminology actually used in any documentation anywhere? And if not
bcahoon updated this revision to Diff 350468.
bcahoon added a comment.
Addressed review comment.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103663/new/
https://reviews.llvm.org/D103663
Files:
clang/include/clang/Basic/Cuda.h
clang/lib/Basic/Cuda.cpp
clang/lib/Basic/Targets/AMD
rampitec added inline comments.
Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:4701
+B.getMF().getFunction().getContext().diagnose(BadIntrin);
+B.buildUndef(MI.getOperand(0));
+MI.eraseFromParent();
You can just omit undef and erase.
CHA
bcahoon added inline comments.
Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:4700
+B.getMF().getFunction().getContext().diagnose(BadIntrin);
+B.buildUndef(MI.getOperand(0));
+MI.eraseFromParent();
rampitec wrote:
> rampitec wrote:
> > Jus
bcahoon updated this revision to Diff 350448.
bcahoon added a comment.
Changed legalizer to return false for raytracing intrinsics that are not
supported by the subtarget. I changed both GlobalISel and regular ISel to work
similarly. A crash occurs with a message that the intrinsic cannot be
le
rampitec added inline comments.
Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:4700
+B.getMF().getFunction().getContext().diagnose(BadIntrin);
+B.buildUndef(MI.getOperand(0));
+MI.eraseFromParent();
rampitec wrote:
> Just return false like
bcahoon marked an inline comment as done.
bcahoon added inline comments.
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:7341
+if (!Subtarget->hasGFX10_AEncoding())
+ emitRemovedIntrinsicError(DAG, DL, Op.getValueType());
+
rampitec wrote:
> return
bcahoon updated this revision to Diff 350423.
bcahoon added a comment.
Addressed review comments
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103663/new/
https://reviews.llvm.org/D103663
Files:
clang/include/clang/Basic/Cuda.h
clang/lib/Basic/Cuda.cpp
clang/lib/Basic/Targets/AMD
rampitec added inline comments.
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.intersect_ray.ll:4
+; RUN: llc -global-isel -march=amdgcn -mcpu=gfx1013 -verify-machineinstrs < %s
| FileCheck -check-prefix=GCN %s
+; RUN: llc -global-isel -march=amdgcn -mcpu=gfx1012 -v
bcahoon marked 4 inline comments as done.
bcahoon added inline comments.
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.intersect_ray.ll:4
+; RUN: llc -global-isel -march=amdgcn -mcpu=gfx1013 -verify-machineinstrs < %s
| FileCheck -check-prefix=GCN %s
+; RUN: llc -g
rampitec added inline comments.
Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:4697
+ if (!ST.hasGFX10_AEncoding()) {
+DiagnosticInfoUnsupported BadIntrin(B.getMF().getFunction(), "intrinsic
not supported on subtarget",
+M
bcahoon marked 8 inline comments as done.
bcahoon added inline comments.
Comment at: llvm/docs/AMDGPUUsage.rst:389
- xnack
scratch - *pal-amdpal*
+ ``gfx1013`` ``amdgcn`` dGPU - cumode
bcahoon updated this revision to Diff 350075.
bcahoon added a comment.
Addressed review comments. Updated the patch to use the new AEncoding target
feature
correctly. Added code to report an error for the image intersect intrinsics for
unsupported targets.
CHANGES SINCE LAST ACTION
https://re
rampitec added inline comments.
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.intersect_ray.ll:4
+; RUN: llc -global-isel -march=amdgcn -mcpu=gfx1013 -verify-machineinstrs < %s
| FileCheck -check-prefix=GCN %s
+; RUN: llc -global-isel -march=amdgcn -mcpu=gfx1012 -v
rampitec added a comment.
You need to replace HasGFX10_BEncoding with HasGFX10_AEncoding in the BVH and
IMAGE_MSAA_LOAD_X. You also need to update llvm.amdgcn.image.msaa.load.x.ll
test to include gfx1013.
Comment at: llvm/lib/Target/AMDGPU/AMDGPU.td:1106
[FeatureGFX10,
foad added inline comments.
Comment at: llvm/docs/AMDGPUUsage.rst:389
- xnack
scratch - *pal-amdpal*
+ ``gfx1013`` ``amdgcn`` dGPU - cumode -
Absolute - *rocm-amdhsa* *TB
foad added a comment.
Please also update `llvm/test/Object/AMDGPU/elf-header-flags-mach.yaml`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103663/new/
https://reviews.llvm.org/D103663
___
cfe-commits m
bcahoon created this revision.
bcahoon added reviewers: rampitec, kzhuravl.
Herald added subscribers: foad, dexonsmith, kerbowa, rupprecht, jfb, hiraditya,
t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, emaste, arsenm, jholewinski.
Herald added a reviewer: jhenderson.
Herald added a reviewer: M
22 matches
Mail list logo
