[PATCH] D103618: [analyzer] Change FindLastStoreBRVisitor to use Tracker

Szelethus added a comment. I know I'm late to the party, and am just mostly thinking aloud. Awesome patch series! Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:331-341 +/// Visitor that tracks expressions and values. +class TrackingBugR

[PATCH] D103618: [analyzer] Change FindLastStoreBRVisitor to use Tracker

vsavchenko added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:367-368 +/// \param Origin Only adds notes when the last store happened in a +///different stackframe to this one. Disregarded if the tracking kind +//

[PATCH] D103618: [analyzer] Change FindLastStoreBRVisitor to use Tracker

Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:367-368 +/// \param Origin Only adds notes when the last store happened in a +///different stackframe to this one. Disregarded if the tracking kind +///

[PATCH] D103618: [analyzer] Change FindLastStoreBRVisitor to use Tracker

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb6bcf953220d: [analyzer] Change FindLastStoreBRVisitor to use Tracker (authored by vsavchenko). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D103618: [analyzer] Change FindLastStoreBRVisitor to use Tracker

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Got it, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103618/new/ https://reviews.llvm.org/D103618 __

[PATCH] D103618: [analyzer] Change FindLastStoreBRVisitor to use Tracker

vsavchenko updated this revision to Diff 351125. vsavchenko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103618/new/ https://reviews.llvm.org/D103618 Files: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter

[PATCH] D103618: [analyzer] Change FindLastStoreBRVisitor to use Tracker

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:2274 + const StackFrameContext *Origin) { + Tracker::create(Report)->track(V, R, Opts, Origin); +} NoQ wrote: > How does lifetim

[PATCH] D103618: [analyzer] Change FindLastStoreBRVisitor to use Tracker

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:2274 + const StackFrameContext *Origin) { + Tracker::create(Report)->track(V, R, Opts, Origin); +} How does lifetime work here? Do I un

[PATCH] D103618: [analyzer] Change FindLastStoreBRVisitor to use Tracker

vsavchenko updated this revision to Diff 349653. vsavchenko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103618/new/ https://reviews.llvm.org/D103618 Files: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter

[PATCH] D103618: [analyzer] Change FindLastStoreBRVisitor to use Tracker

vsavchenko updated this revision to Diff 349563. vsavchenko added a comment. Fix dangling reference problem Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103618/new/ https://reviews.llvm.org/D103618 Files: clang/include/clang/StaticAnalyzer/Core

[PATCH] D103618: [analyzer] Change FindLastStoreBRVisitor to use Tracker

vsavchenko added a comment. This one is completely wrong though. Visitor can definitely outlive Tracker, unlike handlers. I need to use some reference-counting solution here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103618/new/ https://revi

[PATCH] D103618: [analyzer] Change FindLastStoreBRVisitor to use Tracker

vsavchenko updated this revision to Diff 349550. vsavchenko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103618/new/ https://reviews.llvm.org/D103618 Files: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter

[PATCH] D103618: [analyzer] Change FindLastStoreBRVisitor to use Tracker

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, martong, steakhal, Szelethus, manas, RedDocMD. Herald added subscribers: ASDenysPetrov, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this revision.